Skip to content

feat(runtimes): add support for CodeAction and OnDefinition #596

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

feat(runtimes): add support for CodeAction and OnDefinition #596

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8e01473
feat(runtimes): add support for CodeAction
kddejong Jun 23, 2025
291c405
feat(runtimes): add onDefinition to lsp
kddejong Jul 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions runtimes/runtimes/base-runtime.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -267,8 +267,11 @@ export const baseRuntime = (connections: { reader: MessageReader; writer: Messag
sendProgress: <P>(type: ProgressType<P>, token: ProgressToken, value: P) => {
return lspConnection.sendProgress(type, token, value)
},
onDefinition: handler => lspConnection.onDefinition(handler),
onHover: handler => lspConnection.onHover(handler),
onSignatureHelp: handler => lspConnection.onSignatureHelp(handler),
onCodeAction: handler => lspConnection.onCodeAction(handler),
onCodeActionResolve: handler => lspConnection.onCodeActionResolve(handler),
extensions: {
onGetConfigurationFromServer: lspServer.setServerConfigurationHandler,
onInlineCompletionWithReferences: handler =>
Expand Down
3 changes: 3 additions & 0 deletions runtimes/runtimes/standalone.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -408,8 +408,11 @@ export const standalone = (props: RuntimeProps) => {

return lspConnection.sendProgress(type, token, value)
},
onDefinition: handler => lspConnection.onDefinition(handler),
onHover: handler => lspConnection.onHover(handler),
onSignatureHelp: handler => lspConnection.onSignatureHelp(handler),
onCodeAction: handler => lspConnection.onCodeAction(handler),
onCodeActionResolve: handler => lspConnection.onCodeActionResolve(handler),
extensions: {
onGetConfigurationFromServer: lspServer.setServerConfigurationHandler,
onInlineCompletionWithReferences: handler =>
Expand Down
10 changes: 10 additions & 0 deletions runtimes/server-interface/lsp.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ import {
CompletionList,
CompletionParams,
ConfigurationOptions,
DefinitionParams,
DidChangeConfigurationParams,
DidChangeTextDocumentParams,
DidChangeWorkspaceFoldersParams,
Expand All @@ -26,6 +27,8 @@ import {
InlineCompletionList,
InlineCompletionListWithReferences,
InlineCompletionParams,
Location,
LocationLink,
LogInlineCompletionSessionResultsParams,
NotificationHandler,
ProgressToken,
Expand All @@ -48,6 +51,8 @@ import {
ApplyWorkspaceEditParams,
ApplyWorkspaceEditResult,
DidSaveTextDocumentParams,
CodeAction,
CodeActionParams,
DeleteFilesParams,
CreateFilesParams,
RenameFilesParams,
Expand Down Expand Up @@ -131,10 +136,15 @@ export type Lsp = {
onDidSaveTextDocument: (handler: NotificationHandler<DidSaveTextDocumentParams>) => void
publishDiagnostics: (params: PublishDiagnosticsParams) => Promise<void>
sendProgress: <P>(type: ProgressType<P>, token: ProgressToken, value: P) => Promise<void>
onDefinition: (
handler: RequestHandler<DefinitionParams, Location | Location[] | LocationLink[] | null | undefined, void>
) => void
onHover: (handler: RequestHandler<HoverParams, Hover | null | undefined, void>) => void
onExecuteCommand: (handler: RequestHandler<ExecuteCommandParams, any | undefined | null, void>) => void
onSemanticTokens: (handler: RequestHandler<SemanticTokensParams, SemanticTokens | null, void>) => void
onSignatureHelp: (handler: RequestHandler<SignatureHelpParams, SignatureHelp | null | undefined, void>) => void
onCodeAction: (handler: RequestHandler<CodeActionParams, CodeAction[] | null | undefined, void>) => void
onCodeActionResolve: (handler: RequestHandler<CodeAction, CodeAction, void>) => void
workspace: {
getConfiguration: (section: string) => Promise<any>
onDidChangeWorkspaceFolders: (handler: NotificationHandler<DidChangeWorkspaceFoldersParams>) => void
Expand Down