Skip to content

feat(types): add type to executeShellCommandShortCut param #607

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jul 14, 2025
Merged

feat(types): add type to executeShellCommandShortCut param #607

Changes from 4 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
a981bc8
feat(types): add keybinding type for shortcut
dungdong-aws Jul 11, 2025
ca07c5a
fix: generalize usage
dungdong-aws Jul 11, 2025
adb7cde
feat(types): add type for ExecuteShellCommandShortCut
dungdong-aws Jul 14, 2025
d6c6569
fix: make the prop more generic for reusable
dungdong-aws Jul 14, 2025
04e9647
fix: make the interface more generic
dungdong-aws Jul 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions types/chat.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -689,3 +689,7 @@ export interface ListAvailableModelsResult {
models: Model[]
selectedModelId?: string
}

export interface ExecuteShellCommandShortCutParams {
Copy link
Contributor

@laileni-aws laileni-aws Jul 14, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you make this generic ?
Thanks

Copy link
Contributor Author

@dungdong-aws dungdong-aws Jul 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does ExecuteShellCommandParams work?

Copy link
Contributor

@laileni-aws laileni-aws Jul 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes

id: string
}