Skip to content

refactor: sync types with IAM authentication changes #626

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 20 commits into from
Jul 29, 2025
Merged

refactor: sync types with IAM authentication changes #626

merged 20 commits into from
Jul 29, 2025

Conversation

liramon1
Copy link
Contributor

@liramon1 liramon1 commented Jul 18, 2025 •
edited
Loading

Problem

The IAM type changes are behind the changes in aws/language-servers#1869 and aws/language-servers#1846. As a result, the language-servers PRs are unable to compile.

Solution

This is part of #572.

  • Rename validatePermissions to permissionSets and make it accept a list of permissions instead of validating only 1 set of permissions
  • Wrap credentials from getIamCredentialResult into an intermediate object
  • Add credentials override and additional error codes to getIamCredentials
  • Add mfaSerial to GetMfaSerialResult and optionalize it in GetMfaSerialParams

License

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

liramon1 added 16 commits July 7, 2025 12:03
@liramon1
feat(runtimes): add support for IAM and STS credentials management
22f77b0
@liramon1
chore: undo unnecessary changes
d9c4753
@liramon1
fix: re-add IamCredentials change
db626ab
@liramon1
chore: revert EmptyProfile change
306c2b0
@liramon1
refactor: split IamCredentialProfile into multiple profiles
fbfb2d6
@liramon1
chore: revert comment
56fc78a
@liramon1
feat: add mfaCode to getIamCredentialParams
939241b
@liramon1
refactor: prefix IAM-related profiles with 'Iam'
52b509b
@liramon1
refactor: move encryption into separate function and split credential id
d38dbb7
@liramon1
feat: add external_id field to profile
8adfdee
@liramon1
feat: optionalize permission validation in GetIamCredentialOptions
bb6d6a2
@liramon1
refactor: move MFA code retrieval into separate request
7dc451c
@liramon1
fix: add parameters to mfa request
38961c9
@liramon1
fix: naming changes
7948b97
@liramon1
fix: incorporate PR feedback
93e856d
@liramon1
fix: change IamCredential fields
9d1ad6b
@liramon1 liramon1 requested a review from a team as a code owner July 18, 2025 15:42
@liramon1 liramon1 mentioned this pull request Jul 23, 2025
Merged
@liramon1 liramon1 changed the title refactor: rename fields on getIamCredential params and result refactor: sync types with IAM authentication changes Jul 28, 2025
@liramon1 liramon1 mentioned this pull request Jul 28, 2025
Closed
@awschristou awschristou merged commit 844b206 into aws:main Jul 29, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@awschristou awschristou awschristou approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@liramon1 @awschristou