feat: add types for shared credentials file watcher #640
+17
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liramon1
changed the title
liramon1
changed the title
awschristou
reviewed
Aug 1, 2025
runtimes/runtimes/standalone.ts
Outdated
| @@ -304,7 +307,15 @@ export const standalone = (props: RuntimeProps) => { | |||
|
|
|||
| const identityManagement: IdentityManagement = { | |||
| onListProfiles: handler => lspConnection.onRequest(listProfilesRequestType, handler), | |||
| onUpdateProfile: handler => lspConnection.onRequest(updateProfileRequestType, handler), | |||
| onUpdateProfile: handler => | |||
| lspConnection.onRequest( | |||
There was a problem hiding this comment.
Does this send unencrypted profile details to the client?
There was a problem hiding this comment.
No, onUpdateProfile does send anything to the client. onListProfiles would though, so it might be worth encrypting that.
There was a problem hiding this comment.
Oh yes, that would be required.
This reverts commit c0f83ff.
liramon1
changed the title
awschristou
approved these changes
Aug 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The IAM type changes are behind the changes in aws/language-servers#2021. As a result, the language-servers PR is unable to compile.
Solution
License
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.