-
Notifications
You must be signed in to change notification settings - Fork 52
FLARE Protocol Codegen Project to Feature Branch #662
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
constewart9
wants to merge
45
commits into
aws:feature/flareProtocolCodeGen
Choose a base branch
from
constewart9:conorstw/types-NEW
base: feature/flareProtocolCodeGen
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 32 commits
Commits
Show all changes
45 commits
Select commit
Hold shift + click to select a range
d58600d
initial
constewart9 9396507
external definitions allowed
constewart9 b5b753d
added inheritance
constewart9 ff5abb5
feat: inheritance added to relevant definitions
constewart9 7d68a30
feat: renamed generated output package, included post processing
constewart9 2c0bde7
feat: generated types integrated in LSR
constewart9 277801d
feat: removed unncessary flags, cleaned up package.json
constewart9 7e8065e
fix: more git issues fixed
constewart9 03cad90
feat: added java definition codegen
constewart9 2774334
feat: java generation config in openapitools and templates changed dirs
constewart9 7b6be38
fix: update with newest types
constewart9 e628678
fix: removing github actions (moving to different branch
constewart9 08949d5
fix: added readme, updated schema, refactored record.mustace
constewart9 f89388e
test: finish pre/post generation scripts
constewart9 0c0c6f4
fix: refactor package.json
constewart9 9f8907d
test: test to ensure all models are present in output
constewart9 64697eb
refactor: change output schema name
constewart9 342cbb4
Merge remote-tracking branch 'upstream/feature/flareProtocolCodeGen' …
constewart9 8133639
fix: updated README
constewart9 24aa88b
test: added 10 unit tests for config and basic functionality
constewart9 e35bf29
fix: replace github action from branch
constewart9 4997b95
Merge pull request #13 from constewart9/conorstw/types-NEW
constewart9 1be58e9
test: add tests to github action
constewart9 2a37667
Merge pull request #14 from constewart9/conorstw/types-NEW
constewart9 12ba02c
Update package.json
constewart9 9348eff
Update chatTypes.json to remove empty model
constewart9 36b8bf4
Update types-codegen-pr.yaml
constewart9 26e276e
Remove lsp4j addition, moved to generated pom.xml
constewart9 fd71ee2
Update package.json
constewart9 0a00ca6
fix: added pom.xml to be generated with java 21
constewart9 876588b
Merge branch 'main' into conorstw/types-NEW
constewart9 4e18efc
Merge pull request #15 from constewart9/conorstw/types-NEW
constewart9 92fb02d
fix: skip PAC URLs in macOS proxy detection (#664)
tsmithsz 1f14063
chore(release): release packages from branch main (#665)
github-actions[bot] 1494b64
Merge branch 'aws:main' into conorstw/types-NEW
constewart9 d5ef0f3
fix: update the pom.xml generation
constewart9 0f17f60
fix: split schema into different files
constewart9 a7c1712
fix: remove extraneous templates and add gson labels to java
constewart9 252de9c
fix: move external imports to top of file
constewart9 28ee764
fix: initialize telemetry asynchronously without blocking (#666)
chungjac 37d3cfd
chore: add timeout to ensure error flushes to stdout/err on auth fail…
bryceitoc9 e0bd323
fix: updated run scripts
constewart9 719f645
Merge branch 'aws:main' into conorstw/types-NEW
constewart9 5d7fd5e
fix: make local building more robust
constewart9 f28bdd1
fix: add openapi-generator-ignore files to clean up output
constewart9 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,69 @@ | ||
name: Chat Types PR Validation | ||
|
||
on: | ||
pull_request: | ||
branches: | ||
- main | ||
paths: | ||
- 'types/codegen/schema/**' | ||
workflow_dispatch: | ||
|
||
jobs: | ||
validate-pr: | ||
name: Validate PR with chatTypes.json changes | ||
runs-on: ubuntu-latest | ||
|
||
steps: | ||
- name: Checkout repository | ||
uses: actions/checkout@v4 | ||
|
||
- name: Setup Node.js | ||
uses: actions/setup-node@v4 | ||
with: | ||
node-version: '20.x' | ||
#should we cache: 'npm' | ||
|
||
- name: Install root dependencies | ||
working-directory: . | ||
run: npm install | ||
|
||
- name: Install codegen dependencies | ||
working-directory: types/codegen | ||
run: npm install | ||
|
||
- name: Unit tests | ||
constewart9 marked this conversation as resolved.
Show resolved
Hide resolved
|
||
working-directory: types/codegen | ||
run: npm run test:unit | ||
|
||
- name: Coalesce schemas | ||
working-directory: types/codegen | ||
run: npm run generate-full-schema | ||
|
||
- name: Generate types | ||
working-directory: types/codegen | ||
run: npm run generate:only | ||
|
||
- name: Post Process | ||
working-directory: types/codegen | ||
run: npm run post-process | ||
|
||
- name: Completeness Test | ||
working-directory: types/codegen | ||
run: npm run test | ||
|
||
- name: Build TypeScript | ||
working-directory: types/codegen/generated/typescript | ||
run: | | ||
npm i | ||
npm run build | ||
- name: Setup Java | ||
uses: actions/setup-java@v4 | ||
with: | ||
distribution: 'corretto' | ||
java-version: '21' | ||
cache: 'maven' | ||
|
||
- name: Build Java with Maven | ||
working-directory: types/codegen/generated/java | ||
run: | | ||
mvn clean compile -Djava.version=21 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -18,6 +18,7 @@ | |
"author": "Amazon Web Services", | ||
"license": "Apache-2.0", | ||
"dependencies": { | ||
"@aws/language-server-runtimes-types": "^0.1.56" | ||
"@aws/language-server-runtimes-types": "^0.1.56", | ||
"@local/language-server-runtimes-generated-types": "file:../types/codegen/generated/typescript" | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. can you please add a comment here on what the final state should be? |
||
} | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,6 @@ | ||
LICENSE | ||
NOTICE | ||
SECURITY.md | ||
SECURITY.md | ||
codegen/scripts/**/* | ||
codegen/generated/**/* | ||
codegen/tests/fixtures/**/* |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,14 @@ | ||
# Generated code | ||
generated/ | ||
|
||
# Template bank | ||
typescript-template-bank/ | ||
|
||
# OpenAPI generator metadata | ||
.openapi-generator/ | ||
|
||
# Node.js dependencies | ||
node_modules/ | ||
|
||
# Build outputs | ||
dist/ |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be updated?