ci: add comment on pr creation to update language-server-runtime version #671
+20
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laileni-aws
reviewed
Aug 26, 2025
| issue_number: context.issue.number, | ||
| owner: context.repo.owner, | ||
| repo: context.repo.repo, | ||
| body: 'Once this PR is merged and the language-server-runtime package is published, please ensure the corresponding version that contains this commit is updated in language-servers too!' |
There was a problem hiding this comment.
Can we add this in the PR description too?
laileni-aws
approved these changes
Aug 26, 2025
tsmithsz
approved these changes
Aug 26, 2025
|
Can we also add some info to the |
ashishrp-aws
approved these changes
Aug 26, 2025
ctlai95
reviewed
Aug 26, 2025
| issue_number: context.issue.number, | ||
| owner: context.repo.owner, | ||
| repo: context.repo.repo, | ||
| body: 'Once this PR is merged and the language-server-runtime package is published, please ensure the corresponding version that contains this commit is updated in language-servers too!' |
There was a problem hiding this comment.
nit:
Suggested change
| body: 'Once this PR is merged and the language-server-runtime package is published, please ensure the corresponding version that contains this commit is updated in language-servers too!' | |
| body: 'Once this PR is merged and the @aws/language-server-runtimes package is published, please ensure the corresponding version that contains this commit is updated in language-servers too!' |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Solution
Reminder to update language-server-runtime version in language-server repository.
License
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.