Skip to content

Conversation

@chungjac
Copy link
Contributor

@chungjac chungjac commented Dec 2, 2025

Problem

dependency issues

Solution

  1. In this PR: feat: Adding ATX-FES apis support for transformation #2521, the @aws/language-server-runtimes package was changed from using exact version 0.3.6 to ^0.3.8 which allows minor updates. However in app/aws-lsp-partiql-runtimes/package.json, this was updated to 0.3.8 instead of ^0.3.8. Updating it to ^0.3.8 to fix the nested node_modules type conflict issue (pinned version was causing npm to install a separate copy)
  2. Received errors for node-fetch since this is no longer in the dependency tree. We can remove the import type { RequestInit } from 'node-fetch' as we can now use the native fetch which is built into Node 18+
  3. Updated package-lock.json

Testing

npm run clean
npm install
npm run compile

License

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@chungjac chungjac requested a review from a team as a code owner December 2, 2025 00:04
@codecov-commenter
Copy link

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 60.09%. Comparing base (92402ec) to head (b29f791).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2537      +/-   ##
==========================================
- Coverage   60.09%   60.09%   -0.01%     
==========================================
  Files         276      276              
  Lines       65009    65008       -1     
  Branches     4105     4105              
==========================================
- Hits        39068    39067       -1     
  Misses      25858    25858              
  Partials       83       83              
Flag Coverage Δ
unittests 60.09% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@chungjac chungjac marked this pull request as draft December 2, 2025 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants