Skip to content

Conversation

@KevinDing1
Copy link
Contributor

@KevinDing1 KevinDing1 commented Mar 24, 2025

Problem

Initial commit for doc migration to flare
Migrated from aws-toolkit-vscode commit: feat(amazonq): basic paginated suggestions using language server (#6803)

Problem

Solution

Basic paginated inline suggestions implementation using language server
(related: #831)


  • Treat all work as PUBLIC. Private feature/x branches will not be
    squash-merged at release time.
  • Your code changes must meet the guidelines in
    CONTRIBUTING.md.
  • License: I confirm that my contribution is made under the terms of the
    Apache 2.0 license.e01574f3427de0bef053662707bd4cea95f8986f

Testing: how did you test your changes?

Passed local build

License

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@KevinDing1 KevinDing1 requested a review from a team as a code owner March 24, 2025 15:05
Copy link
Contributor

@jpinkney-aws jpinkney-aws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is it worth calling out what commit id we ported from? Just so we know if anything needs to be migrated after

@@ -0,0 +1,3 @@
export function i18n(text: string): string {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is just a stub because we didn't know what support flare has (or is going to have) for i18n

pillText: 'Yes',
prompt: 'Yes',
status: 'success' as Status,
type: FollowUpTypes.ProceedFolderSelection,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Presumably these are going to change, but for now we copied in their dependencies so this can build

@KevinDing1
Copy link
Contributor Author

is it worth calling out what commit id we ported from? Just so we know if anything needs to be migrated after

Yeah, i updated the commit Id in the PR description

@KevinDing1 KevinDing1 enabled auto-merge (squash) March 24, 2025 16:15
@KevinDing1 KevinDing1 merged commit e163d5d into aws:main Mar 26, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants