fix: Dropdowns not closing when selected option is reselected #378
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dogusata
previously approved these changes
Jun 25, 2025
|
Please recheck the tests |
dogusata
approved these changes
Jun 27, 2025
|
Closing this PR and overriding select elements only in JetBrains cause this problem is widely seen in JetBrains and the fix causes regressions in Eclipse: aws/aws-toolkit-jetbrains#5878 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Dropdowns were not closing when a selected option was reselected. Customers had to click multiple times outside the chat to close the dropdowns.
Solution
Setting menulist properties ensures that select dropdowns maintain their native operating system behavior.
This was causing a side effect of custom arrows and native arrows being rendered twice. So the custom arrows on select elements have been hidden. Removing them entirely results in text being truncated in the dropdown appearance.
Tests
License
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.