Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -139,6 +139,13 @@ class RemoteExtensionHostAgentServer extends Disposable implements IServerAPI {
if (pathname === '/vscode-remote-resource') {
// Handle HTTP requests for resources rendered in the rich client (images, fonts, etc.)
// These resources could be files shipped with extensions or even workspace files.
if (req.headers.referer && req.headers.host) {
const parsedRefererUrl = url.parse(req.headers.referer, true);
if (parsedRefererUrl.host !== req.headers.host) {
return serveError(req, res, 403, `Forbidden.`);
}
}

const desiredPath = parsedUrl.query['path'];
if (typeof desiredPath !== 'string') {
return serveError(req, res, 400, `Bad request.`);
Expand Down
1 change: 1 addition & 0 deletions patches/series
Original file line number Diff line number Diff line change
Expand Up @@ -18,3 +18,4 @@ sagemaker-extension-smus-support.patch
post-startup-notifications.patch
sagemaker-extensions-sync.patch
display-language.patch
validate-http-request-referer.patch
18 changes: 18 additions & 0 deletions patches/validate-http-request-referer.patch
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
Index: sagemaker-code-editor/vscode/src/vs/server/node/remoteExtensionHostAgentServer.ts
===================================================================
--- sagemaker-code-editor.orig/vscode/src/vs/server/node/remoteExtensionHostAgentServer.ts
+++ sagemaker-code-editor/vscode/src/vs/server/node/remoteExtensionHostAgentServer.ts
@@ -139,6 +139,13 @@ class RemoteExtensionHostAgentServer ext
if (pathname === '/vscode-remote-resource') {
// Handle HTTP requests for resources rendered in the rich client (images, fonts, etc.)
// These resources could be files shipped with extensions or even workspace files.
+ if (req.headers.referer && req.headers.host) {
+ const parsedRefererUrl = url.parse(req.headers.referer, true);
+ if (parsedRefererUrl.host !== req.headers.host) {
+ return serveError(req, res, 403, `Forbidden.`);
+ }
+ }
+
const desiredPath = parsedUrl.query['path'];
if (typeof desiredPath !== 'string') {
return serveError(req, res, 400, `Bad request.`);