Skip to content

Disabling the SageMaker Specific Post Startup Scripts #805

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Manojtuguru
Copy link

@Manojtuguru Manojtuguru commented Jul 30, 2025

Description

Disabling the SageMaker Specific Post Startup Scripts

Type of Change

  • Image update - Bug fix
  • Image update - New feature
  • Image update - Breaking change
  • SMD image build tool update
  • Documentation update

Release Information

Does this change need to be included in patch version releases? By default, any pull requests will only be added to the next SMD image minor version release once they are merged in template folder. Only critical bug fix or security update should be applied to new patch versions of existed image minor versions.

  • Yes (Critical bug fix or security update)
  • No (New feature or non-critical change)
  • N/A (Not an image update)

If yes, please explain why:
We do not want the SMUS Post start up scripts to show in the SMAI, so we need this change merged.

How Has This Been Tested?

The test was to check if the Post start up Scripts show in the SMAI image and it doesn't show up

Checklist:

  • My code follows the style guidelines of this project
  • [x ] I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works

Test Screenshots (if applicable):

Additional Notes

This is to update the Disable the SageMaker Specific Post Startup Scripts to so they wouldn't be invoked in the SMAI images.

@Manojtuguru Manojtuguru requested a review from a team as a code owner July 30, 2025 02:46
@Manojtuguru Manojtuguru changed the title Disabling the Post Startup Script for the SMAI Disabling the SageMaker Specific Post Startup Scripts Jul 30, 2025
@omursalo
Copy link
Contributor

omursalo commented Aug 6, 2025

LGTM - can you add some details to the PR such as why this change is needed and how we tested.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants