Skip to content

Fix: Update model card for model package with no existing model card #4794

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 25, 2024
Merged

Fix: Update model card for model package with no existing model card #4794

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a132a19
Fix: Update model card for model package with no existing model card
selvask-aws Jul 23, 2024
45b5ae9
Merge branch 'master' into fix/model-card-update
selvask-aws Jul 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
75 changes: 49 additions & 26 deletions src/sagemaker/model.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2466,32 +2466,55 @@ def update_model_card(self, model_card: Union[ModelCard, ModelPackageModelCard])
desc_model_package = sagemaker_session.sagemaker_client.describe_model_package(
ModelPackageName=self.model_package_arn
)
if hasattr(model_card, "model_package_details"):
model_card.model_package_details = None
update_model_card_req = model_card._create_request_args()
if update_model_card_req["ModelCardStatus"] is not None:
if (
desc_model_package["ModelCard"]["ModelCardStatus"]
== update_model_card_req["ModelCardStatus"]
):
del update_model_card_req["ModelCardStatus"]

if update_model_card_req.get("ModelCardName") is not None:
del update_model_card_req["ModelCardName"]
if update_model_card_req.get("Content") is not None:
previous_content_hash = _hash_content_str(
desc_model_package["ModelCard"]["ModelCardContent"]
)
current_content_hash = _hash_content_str(update_model_card_req["Content"])
if (
previous_content_hash == current_content_hash
or update_model_card_req.get("Content") == "{}"
or update_model_card_req.get("Content") == "null"
):
del update_model_card_req["Content"]
else:
update_model_card_req["ModelCardContent"] = update_model_card_req["Content"]
del update_model_card_req["Content"]
update_model_package_args = {
"ModelPackageArn": self.model_package_arn,
"ModelCard": update_model_card_req,
}
sagemaker_session.sagemaker_client.update_model_package(**update_model_package_args)
if update_model_card_req["Content"] is not None:
if "model_package_details" in update_model_card_req["Content"]:
update_model_card_req["Content"].pop("model_package_details", None)
update_model_card_req["ModelCardContent"] = update_model_card_req["Content"]
del update_model_card_req["Content"]

if "ModelCard" in desc_model_package:
if update_model_card_req["ModelCardStatus"] is not None:
if (
desc_model_package["ModelCard"]["ModelCardStatus"]
!= update_model_card_req["ModelCardStatus"]
):
new_mc_mp_req = update_model_card_req
del new_mc_mp_req["ModelCardContent"]
update_model_package_args = {
"ModelPackageArn": self.model_package_arn,
"ModelCard": new_mc_mp_req,
}
sagemaker_session.sagemaker_client.update_model_package(
**update_model_package_args
)

if update_model_card_req.get("ModelCardContent") is not None:
previous_content_hash = _hash_content_str(
desc_model_package["ModelCard"]["ModelCardContent"]
)
current_content_hash = _hash_content_str(update_model_card_req["ModelCardContent"])
if not (
previous_content_hash == current_content_hash
or update_model_card_req.get("ModelCardContent") == "{}"
or update_model_card_req.get("ModelCardContent") == "null"
):
new_mc_mp_req = update_model_card_req
del new_mc_mp_req["ModelCardStatus"]
update_model_package_args = {
"ModelPackageArn": self.model_package_arn,
"ModelCard": new_mc_mp_req,
}
sagemaker_session.sagemaker_client.update_model_package(
**update_model_package_args
)
else:
update_model_package_args = {
"ModelPackageArn": self.model_package_arn,
"ModelCard": update_model_card_req,
}
sagemaker_session.sagemaker_client.update_model_package(**update_model_package_args)
Loading