-
Notifications
You must be signed in to change notification settings - Fork 1.2k
TF-2.16 test modification and handling #4830
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 19 commits
50cf9aa
80f7875
0a2ed3d
2a2dfd0
e359e21
c95a787
dc522e6
5625988
3036cce
5711a20
c053583
0529828
8690405
3ad5961
a2b424d
7a13af7
4147f69
48c2507
d1a3475
8493136
3e55e7d
5e6ff38
3f11254
7c5add1
3c7135e
f7cf9d3
d88af35
3751a63
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -331,7 +331,8 @@ | |
"2.11": "2.11.1", | ||
"2.12": "2.12.1", | ||
"2.13": "2.13.0", | ||
"2.14": "2.14.1" | ||
"2.14": "2.14.1", | ||
"2.16": "2.16.1" | ||
}, | ||
"versions": { | ||
"1.4.1": { | ||
|
@@ -2188,6 +2189,48 @@ | |
"us-west-2": "763104351884" | ||
}, | ||
"repository": "tensorflow-inference" | ||
}, | ||
"2.16.1": { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Same for this, will be reverted and added via auto-commits |
||
"registries": { | ||
"af-south-1": "626614931356", | ||
"ap-east-1": "871362719292", | ||
"ap-northeast-1": "763104351884", | ||
"ap-northeast-2": "763104351884", | ||
"ap-northeast-3": "364406365360", | ||
"ap-south-1": "763104351884", | ||
"ap-south-2": "772153158452", | ||
"ap-southeast-1": "763104351884", | ||
"ap-southeast-2": "763104351884", | ||
"ap-southeast-3": "907027046896", | ||
"ap-southeast-4": "457447274322", | ||
"ca-central-1": "763104351884", | ||
"ca-west-1": "204538143572", | ||
"cn-north-1": "727897471807", | ||
"cn-northwest-1": "727897471807", | ||
"eu-central-1": "763104351884", | ||
"eu-central-2": "380420809688", | ||
"eu-north-1": "763104351884", | ||
"eu-south-1": "692866216735", | ||
"eu-south-2": "503227376785", | ||
"eu-west-1": "763104351884", | ||
"eu-west-2": "763104351884", | ||
"eu-west-3": "763104351884", | ||
"il-central-1": "780543022126", | ||
"me-central-1": "914824155844", | ||
"me-south-1": "217643126080", | ||
"sa-east-1": "763104351884", | ||
"us-east-1": "763104351884", | ||
"us-east-2": "763104351884", | ||
"us-gov-east-1": "446045086412", | ||
"us-gov-west-1": "442386744353", | ||
"us-iso-east-1": "886529160074", | ||
"us-isob-east-1": "094389454867", | ||
"us-isof-east-1": "303241398832", | ||
"us-isof-south-1": "454834333376", | ||
"us-west-1": "763104351884", | ||
"us-west-2": "763104351884" | ||
}, | ||
"repository": "tensorflow-inference" | ||
} | ||
} | ||
}, | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -22,6 +22,7 @@ | |
|
||
from botocore.config import Config | ||
from packaging.version import Version | ||
from packaging.specifiers import SpecifierSet | ||
|
||
from sagemaker import Session, image_uris, utils, get_execution_role | ||
from sagemaker.local import LocalSession | ||
|
@@ -555,6 +556,11 @@ def tf_full_version(tensorflow_training_latest_version, tensorflow_inference_lat | |
Fixture exists as such, since TF training and TFS have different latest versions. | ||
Otherwise, this would simply be a single latest version. | ||
""" | ||
if Version(tensorflow_training_latest_version) in SpecifierSet(">=2.16"): | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Nit: you can prob just assign a variable for the version object so you don't have to reinstantiate multiple times There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Thanks, made the change |
||
return ( | ||
f"{Version(tensorflow_training_latest_version).major}" | ||
f".{Version(tensorflow_training_latest_version).minor}" | ||
) | ||
return str( | ||
min( | ||
Version(tensorflow_training_latest_version), | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will be reverted and added via automated commits