Skip to content

fix: disable failing integration tests #4841

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 16, 2024
Merged

fix: disable failing integration tests #4841

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
017ac25
Disable failing integration tests
pintaoz-aws Aug 16, 2024
d7ba27b
run formatter
pintaoz-aws Aug 16, 2024
fd0c1b7
fix error
pintaoz-aws Aug 16, 2024
4e57adc
remove .keras
pintaoz-aws Aug 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion tests/data/tensorflow_mnist/mnist_v2.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -198,7 +198,7 @@ def main(args):

if args.current_host == args.hosts[0]:
ckpt_manager.save()
net.save("/opt/ml/model/1.keras")
net.save("/opt/ml/model/1")


if __name__ == "__main__":
Expand Down
10 changes: 10 additions & 0 deletions tests/integ/test_tf.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,6 +85,11 @@ def test_mnist_with_checkpoint_config(
tensorflow_training_latest_version,
tensorflow_training_latest_py_version,
):
if Version(tensorflow_training_latest_version) >= Version("2.16"):
pytest.skip(
"This test is failing in TensorFlow 2.16 beacuse of an upstream bug: "
"https://github.com/tensorflow/io/issues/2039"
)
checkpoint_s3_uri = "s3://{}/checkpoints/tf-{}".format(
sagemaker_session.default_bucket(), sagemaker_timestamp()
)
Expand Down Expand Up @@ -235,6 +240,11 @@ def test_mnist_distributed_cpu(
tensorflow_training_latest_version,
tensorflow_training_latest_py_version,
):
if Version(tensorflow_training_latest_version) >= Version("2.16"):
pytest.skip(
"This test is failing in TensorFlow 2.16 beacuse of an upstream bug: "
"https://github.com/tensorflow/io/issues/2039"
)
_create_and_fit_estimator(
sagemaker_session,
tensorflow_training_latest_version,
Expand Down
11 changes: 11 additions & 0 deletions tests/integ/test_tuner.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@
import numpy as np
import pytest
from botocore.exceptions import ClientError
from packaging.version import Version

import tests.integ
from sagemaker import KMeans, LDA, RandomCutForest, image_uris
Expand Down Expand Up @@ -691,6 +692,11 @@ def test_tuning_tf(
tensorflow_training_latest_version,
tensorflow_training_latest_py_version,
):
if Version(tensorflow_training_latest_version) >= Version("2.16"):
pytest.skip(
"This test is failing in TensorFlow 2.16 beacuse of an upstream bug: "
"https://github.com/tensorflow/io/issues/2039"
)
resource_path = os.path.join(DATA_DIR, "tensorflow_mnist")
script_path = "mnist.py"

Expand Down Expand Up @@ -735,6 +741,11 @@ def test_tuning_tf_vpc_multi(
tensorflow_training_latest_py_version,
):
"""Test Tensorflow multi-instance using the same VpcConfig for training and inference"""
if Version(tensorflow_training_latest_version) >= Version("2.16"):
pytest.skip(
"This test is failing in TensorFlow 2.16 beacuse of an upstream bug: "
"https://github.com/tensorflow/io/issues/2039"
)
instance_type = cpu_instance_type
instance_count = 2

Expand Down