Skip to content

Conversation

@benieric
Copy link
Contributor

@benieric benieric commented Jan 9, 2025

Issue #, if available:

Description of changes:

  • Twine does not yet support core-metadata-version 2.4 which is new default for hatchling. Pinning to unblock

Testing done:

root@b3e99f464864:/sagemaker-python-sdk# python3 -m twine check --strict dist/*
Checking dist/sagemaker-2.237.4.dev0-py3-none-any.whl: PASSED
Checking dist/sagemaker-2.237.4.dev0.tar.gz: PASSED
root@b3e99f464864:/sagemaker-python-sdk# git diff
diff --git a/pyproject.toml b/pyproject.toml
index 21eb1850..7711249c 100644
--- a/pyproject.toml
+++ b/pyproject.toml
@@ -73,6 +73,7 @@ pattern = "(?P<version>.+)"
 [tool.hatch.metadata.hooks.custom]

 [tool.hatch.build.targets.wheel]
+core-metadata-version = "2.3"
 packages = ["src/sagemaker"]
 exclude = ["src/sagemaker/serve/model_server/triton/pack_conda_env.sh"]

@@ -80,6 +81,7 @@ exclude = ["src/sagemaker/serve/model_server/triton/pack_conda_env.sh"]
 "src/sagemaker/serve/model_server/triton/pack_conda_env.sh" = "pack_conda_env.sh"

 [tool.hatch.build.targets.sdist]
+core-metadata-version = "2.3"
 only-include = [
   "/requirements/extras",
   "/src",

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

  • I have read the CONTRIBUTING doc
  • I certify that the changes I am introducing will be backward compatible, and I have discussed concerns about this, if any, with the Python SDK team
  • I used the commit message format described in CONTRIBUTING
  • I have passed the region in to all S3 and STS clients that I've initialized as part of this change.
  • I have updated any necessary documentation, including READMEs and API docs (if appropriate)

Tests

  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have added unit and/or integration tests as appropriate to ensure backward compatibility of the changes
  • I have checked that my tests are not configured for a specific region or account (if appropriate)
  • I have used unique_name_from_base to create resource names in integ tests (if appropriate)
  • If adding any dependency in requirements.txt files, I have spell checked and ensured they exist in PyPi

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@benieric benieric requested a review from a team as a code owner January 9, 2025 20:28
@benieric benieric requested a review from nargokul January 9, 2025 20:28
@mufaddal-rohawala mufaddal-rohawala merged commit 96c5002 into aws:master Jan 9, 2025
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants