Skip to content

Raise error early for MLFlow in local container mode #4993

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Raise error early for MLFlow in local container mode #4993

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f74fd75
Raise error early for MLFlow in local container mode
ruiliann666 Jan 14, 2025
804123c
Improve error message
ruiliann666 Jan 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions src/sagemaker/serve/builder/model_builder.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -883,6 +883,16 @@ def build( # pylint: disable=R0911

if mode:
self.mode = mode

if self.mode == Mode.LOCAL_CONTAINER and (
self.model_metadata and (
"MLFLOW_MODEL_PATH" in self.model_metadata or
"MLFLOW_TRACKING_ARN" in self.model_metadata
)
):
raise ValueError("MLflow model support is not available for Mode.LOCAL_CONTAINER. "
"Please use Mode.SAGEMAKER_ENDPOINT for MLflow models.")

Comment on lines +886 to +895
Copy link
Contributor

@nargokul nargokul Jan 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a unit test

if role_arn:
self.role_arn = role_arn

Expand Down
Loading