Skip to content

fix: skip TF tests for unsupported versions #5007

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 28, 2025
Merged

fix: skip TF tests for unsupported versions #5007

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
46d069d
fix: skip TF tests for unsupported versions
benieric Jan 28, 2025
2624156
flake8
benieric Jan 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions tests/integ/sagemaker/workflow/test_model_create_and_registration.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,6 @@
import pytest

from packaging.version import Version
from packaging.specifiers import SpecifierSet

from sagemaker.model_card.model_card import ModelCard, ModelOverview, ModelPackageModelCard
from sagemaker.model_card.schema_constraints import ModelCardStatusEnum
Expand Down Expand Up @@ -1422,7 +1421,7 @@ def test_model_registration_with_tensorflow_model_with_pipeline_model(
pipeline_name,
region_name,
):
if Version(tf_full_version) in SpecifierSet("==2.16.*"):
if Version(tf_full_version) >= Version("2.16"):
pytest.skip(
"This test is failing in TensorFlow 2.16 beacuse of an upstream bug: "
"https://github.com/tensorflow/io/issues/2039"
Expand Down
3 changes: 1 addition & 2 deletions tests/integ/sagemaker/workflow/test_model_steps.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@
import pytest

from packaging.version import Version
from packaging.specifiers import SpecifierSet

from tests.integ.sagemaker.workflow.helpers import wait_pipeline_execution
from sagemaker.workflow.fail_step import FailStep
Expand Down Expand Up @@ -592,7 +591,7 @@ def test_model_registration_with_drift_check_baselines_and_model_metrics(
def test_model_registration_with_tensorflow_model_with_pipeline_model(
pipeline_session, role, tf_full_version, tf_full_py_version, pipeline_name
):
if Version(tf_full_version) in SpecifierSet("==2.16.*"):
if Version(tf_full_version) >= Version("2.16"):
pytest.skip(
"This test is failing in TensorFlow 2.16 beacuse of an upstream bug: "
"https://github.com/tensorflow/io/issues/2039"
Expand Down
3 changes: 1 addition & 2 deletions tests/integ/sagemaker/workflow/test_training_steps.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,6 @@
import pytest

from packaging.version import Version
from packaging.specifiers import SpecifierSet

from tests.integ.sagemaker.workflow.helpers import wait_pipeline_execution
from sagemaker import TrainingInput, get_execution_role, utils, image_uris
Expand Down Expand Up @@ -238,7 +237,7 @@ def test_training_step_with_output_path_as_join(
def test_tensorflow_training_step_with_parameterized_code_input(
pipeline_session, role, tf_full_version, tf_full_py_version, pipeline_name
):
if Version(tf_full_version) in SpecifierSet("==2.16.*"):
if Version(tf_full_version) >= Version("2.16"):
pytest.skip(
"This test is failing in TensorFlow 2.16 beacuse of an upstream bug: "
"https://github.com/tensorflow/io/issues/2039"
Expand Down
3 changes: 1 addition & 2 deletions tests/integ/test_transformer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,6 @@
import pytest

from packaging.version import Version
from packaging.specifiers import SpecifierSet

from sagemaker import KMeans, s3, get_execution_role
from sagemaker.mxnet import MXNet
Expand Down Expand Up @@ -556,7 +555,7 @@ def test_transform_mxnet_logs(
def test_transform_tf_kms_network_isolation(
sagemaker_session, cpu_instance_type, tmpdir, tf_full_version, tf_full_py_version
):
if Version(tf_full_version) in SpecifierSet("==2.16.*"):
if Version(tf_full_version) >= Version("2.16"):
pytest.skip(
"This test is failing in TensorFlow 2.16 beacuse of an upstream bug: "
"https://github.com/tensorflow/io/issues/2039"
Expand Down
Loading