Skip to content

Add warning about not supporting torch.nn.SyncBatchNorm #5046

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 18, 2025
Merged

Add warning about not supporting torch.nn.SyncBatchNorm #5046

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9579593
Add warning about not supporting
Feb 18, 2025
e17131e
update wording
Feb 18, 2025
7f0f4d4
Merge branch 'master' into syncbatchnorm
pintaoz-aws Feb 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions doc/frameworks/pytorch/using_pytorch.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -375,6 +375,8 @@ To initialize distributed training in your script, call
`torch.distributed.init_process_group
<https://pytorch.org/docs/master/distributed.html#torch.distributed.init_process_group>`_
with the desired backend and the rank of the current host.
Warning: ``torch.nn.SyncBatchNorm`` is not supported and its existence in
``init_process_group`` will cause an exception during distributed training.
Copy link
Contributor

@nargokul nargokul Feb 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we make the wording more generic instead of just this use case ?

smdistributed with init_process_group will not allow use of certain other torch features, such as (and likely not limited to) torch.nn.SyncBatchNorm.

Copy link
Contributor Author

@pintaoz-aws pintaoz-aws Feb 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated


.. code:: python

Expand Down
Loading