Skip to content

Conversation

@malav-shastri
Copy link
Member

Issue #, if available:

Description of changes:

Testing done:

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

  • I have read the CONTRIBUTING doc
  • I certify that the changes I am introducing will be backward compatible, and I have discussed concerns about this, if any, with the Python SDK team
  • I used the commit message format described in CONTRIBUTING
  • I have passed the region in to all S3 and STS clients that I've initialized as part of this change.
  • I have updated any necessary documentation, including READMEs and API docs (if appropriate)

Tests

  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have added unit and/or integration tests as appropriate to ensure backward compatibility of the changes
  • I have checked that my tests are not configured for a specific region or account (if appropriate)
  • I have used unique_name_from_base to create resource names in integ tests (if appropriate)
  • If adding any dependency in requirements.txt files, I have spell checked and ensured they exist in PyPi

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

}
}
},
"4.48.0": {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does this image not need to be added to the tests?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

couldn't find any tests which needed to be changed for this

@Aditi2424 Aditi2424 merged commit 8a559ad into aws:master Feb 20, 2025
13 of 14 checks passed
bencrabtree pushed a commit to bencrabtree/sagemaker-python-sdk that referenced this pull request Feb 20, 2025
Aditi2424 pushed a commit that referenced this pull request Feb 24, 2025
* fix altconfig hubcontent and reenable integ test

* linting

* update exception thrown

* feat: Add support for TGI Neuronx 0.0.27 and HF PT 2.3.0 image in PySDK (#5050)

Co-authored-by: malavhs <[email protected]>

* add test

* update predictor spec accessor

* lint

* set custom field from HCD config to model spec data class

* lint

* remove logs

* last update

---------

Co-authored-by: Malav Shastri <[email protected]>
Co-authored-by: malavhs <[email protected]>
evakravi pushed a commit to evakravi/sagemaker-python-sdk that referenced this pull request Mar 20, 2025
evakravi pushed a commit to evakravi/sagemaker-python-sdk that referenced this pull request Mar 20, 2025
* fix altconfig hubcontent and reenable integ test

* linting

* update exception thrown

* feat: Add support for TGI Neuronx 0.0.27 and HF PT 2.3.0 image in PySDK (aws#5050)

Co-authored-by: malavhs <[email protected]>

* add test

* update predictor spec accessor

* lint

* set custom field from HCD config to model spec data class

* lint

* remove logs

* last update

---------

Co-authored-by: Malav Shastri <[email protected]>
Co-authored-by: malavhs <[email protected]>
pravali96 pushed a commit to pravali96/sagemaker-python-sdk that referenced this pull request Apr 21, 2025
pravali96 pushed a commit to pravali96/sagemaker-python-sdk that referenced this pull request Apr 21, 2025
* fix altconfig hubcontent and reenable integ test

* linting

* update exception thrown

* feat: Add support for TGI Neuronx 0.0.27 and HF PT 2.3.0 image in PySDK (aws#5050)

Co-authored-by: malavhs <[email protected]>

* add test

* update predictor spec accessor

* lint

* set custom field from HCD config to model spec data class

* lint

* remove logs

* last update

---------

Co-authored-by: Malav Shastri <[email protected]>
Co-authored-by: malavhs <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants