-
Notifications
You must be signed in to change notification settings - Fork 1.2k
feat: Allow ModelTrainer to accept hyperparameters file #5059
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
benieric
merged 15 commits into
aws:master
from
benieric:master-model-trainer-hyperparameters
Mar 5, 2025
Merged
Changes from 4 commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
dc5ac8f
Allow ModelTrainer to accept hyperparameter file and create Hyperpara…
benieric e4474fa
pylint
benieric 1c45f14
Detect hyperparameters from contents rather than file extension
benieric f8f0854
pylint
benieric f8cc961
change: add integs
benieric a5dba4b
change: add integs
benieric 337850e
change: remove custom hyperparameter tooling
benieric e42af65
Add tests for hp contracts
benieric 155a6b8
change: add unit tests and remove unreachable condition
benieric b139afb
Merge branch 'master' into master-model-trainer-hyperparameters
benieric 3f0b85e
fix integs
benieric 4643d81
doc check fix
benieric cf4cb16
fix tests
benieric c86082f
fix tox.ini
benieric 979e10f
add unit test
benieric File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,113 @@ | ||
# Copyright Amazon.com, Inc. or its affiliates. All Rights Reserved. | ||
# | ||
# Licensed under the Apache License, Version 2.0 (the "License"). You | ||
# may not use this file except in compliance with the License. A copy of | ||
# the License is located at | ||
# | ||
# http://aws.amazon.com/apache2.0/ | ||
# | ||
# or in the "license" file accompanying this file. This file is | ||
# distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF | ||
# ANY KIND, either express or implied. See the License for the specific | ||
# language governing permissions and limitations under the License. | ||
"""Hyperparameters class module.""" | ||
from __future__ import absolute_import | ||
|
||
import os | ||
import json | ||
import dataclasses | ||
from typing import Any, Type, TypeVar | ||
|
||
from sagemaker.modules import logger | ||
|
||
T = TypeVar("T") | ||
|
||
|
||
class DictConfig: | ||
"""Class that supports both dict and dot notation access""" | ||
|
||
def __init__(self, **kwargs): | ||
# Store the original dict | ||
self._data = kwargs | ||
|
||
# Set all items as attributes for dot notation | ||
for key, value in kwargs.items(): | ||
# Recursively convert nested dicts to DictConfig | ||
if isinstance(value, dict): | ||
value = DictConfig(**value) | ||
setattr(self, key, value) | ||
|
||
def __getitem__(self, key: str) -> Any: | ||
"""Enable dictionary-style access: config['key']""" | ||
return self._data[key] | ||
|
||
def __setitem__(self, key: str, value: Any): | ||
"""Enable dictionary-style assignment: config['key'] = value""" | ||
self._data[key] = value | ||
setattr(self, key, value) | ||
|
||
def __str__(self) -> str: | ||
"""String representation""" | ||
return str(self._data) | ||
|
||
def __repr__(self) -> str: | ||
"""Detailed string representation""" | ||
return f"DictConfig({self._data})" | ||
|
||
|
||
class Hyperparameters: | ||
"""Class to load hyperparameters in training container.""" | ||
|
||
@staticmethod | ||
def load() -> DictConfig: | ||
"""Loads hyperparameters in training container | ||
|
||
Example: | ||
|
||
.. code:: python | ||
from sagemaker.modules.hyperparameters import Hyperparameters | ||
|
||
hps = Hyperparameters.load() | ||
print(hps.batch_size) | ||
|
||
Returns: | ||
DictConfig: hyperparameters as a DictConfig object | ||
""" | ||
hps = json.loads(os.environ.get("SM_HPS", "{}")) | ||
if not hps: | ||
logger.warning("No hyperparameters found in SM_HPS environment variable.") | ||
return DictConfig(**hps) | ||
|
||
@staticmethod | ||
def load_structured(dataclass_type: Type[T]) -> T: | ||
"""Loads hyperparameters as a structured dataclass | ||
|
||
Example: | ||
|
||
.. code:: python | ||
from sagemaker.modules.hyperparameters import Hyperparameters | ||
|
||
@dataclass | ||
class TrainingConfig: | ||
batch_size: int | ||
learning_rate: float | ||
|
||
config = Hyperparameters.load_structured(TrainingConfig) | ||
print(config.batch_size) # typed int | ||
|
||
Args: | ||
dataclass_type: Dataclass type to structure the config | ||
|
||
Returns: | ||
dataclass_type: Instance of provided dataclass type | ||
""" | ||
|
||
if not dataclasses.is_dataclass(dataclass_type): | ||
raise ValueError(f"{dataclass_type} is not a dataclass type.") | ||
|
||
hps = json.loads(os.environ.get("SM_HPS", "{}")) | ||
if not hps: | ||
logger.warning("No hyperparameters found in SM_HPS environment variable.") | ||
|
||
# Convert hyperparameters to dataclass | ||
return dataclass_type(**hps) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.