Skip to content

Fix error when there is no session to call _create_model_request() #5062

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 5, 2025
+17 −0
Merged

Fix error when there is no session to call _create_model_request() #5062

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
12456b1
Fix error when there is no session to call _create_model_request()
Feb 26, 2025
7a8cd34
Fix codestyle
Feb 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions src/sagemaker/pipeline.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,8 @@

import sagemaker
from sagemaker import ModelMetrics, Model
from sagemaker import local
from sagemaker import session
from sagemaker.config import (
ENDPOINT_CONFIG_KMS_KEY_ID_PATH,
MODEL_VPC_CONFIG_PATH,
Expand Down Expand Up @@ -560,3 +562,16 @@ def delete_model(self):
raise ValueError("The SageMaker model must be created before attempting to delete.")

self.sagemaker_session.delete_model(self.name)

def _init_sagemaker_session_if_does_not_exist(self, instance_type=None):
"""Set ``self.sagemaker_session`` to ``LocalSession`` or ``Session`` if it's not already.

The type of session object is determined by the instance type.
"""
if self.sagemaker_session:
return

if instance_type in ("local", "local_gpu"):
self.sagemaker_session = local.LocalSession(sagemaker_config=self._sagemaker_config)
else:
self.sagemaker_session = session.Session(sagemaker_config=self._sagemaker_config)
2 changes: 2 additions & 0 deletions src/sagemaker/workflow/steps.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -645,6 +645,7 @@ def arguments(self) -> RequestType:
request_dict = self.step_args
else:
if isinstance(self.model, PipelineModel):
self.model._init_sagemaker_session_if_does_not_exist()
request_dict = self.model.sagemaker_session._create_model_request(
name="",
role=self.model.role,
Expand All @@ -653,6 +654,7 @@ def arguments(self) -> RequestType:
enable_network_isolation=self.model.enable_network_isolation,
)
else:
self.model._init_sagemaker_session_if_does_not_exist()
request_dict = self.model.sagemaker_session._create_model_request(
Copy link
Contributor

@nargokul nargokul Feb 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to include the

instance_type

parameter here ?

Copy link
Contributor Author

@pintaoz-aws pintaoz-aws Feb 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these workflow step won't be run on local mode, so the instance type can be set as default to None here

name="",
role=self.model.role,
Expand Down