Skip to content

fix: fix flaky clarify model monitor test #5107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 27, 2025
Merged

fix: fix flaky clarify model monitor test #5107

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions tests/unit/sagemaker/monitor/test_clarify_model_monitor.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -568,11 +568,12 @@ def test_clarify_model_monitor():

# The subclass should has monitoring_type() defined
# noinspection PyAbstractClass
class DummyClarifyModelMonitoir(ClarifyModelMonitor):
class DummyClarifyModelMonitor(ClarifyModelMonitor):
_TEST_CLASS = True
pass

with pytest.raises(TypeError):
DummyClarifyModelMonitoir.monitoring_type()
DummyClarifyModelMonitor.monitoring_type()


def test_clarify_model_monitor_invalid_update(clarify_model_monitors):
Expand All @@ -593,6 +594,8 @@ def test_clarify_model_monitor_invalid_attach(sagemaker_session):
)
# attach, invalid monitoring type
for clarify_model_monitor_cls in ClarifyModelMonitor.__subclasses__():
if hasattr(clarify_model_monitor_cls, "_TEST_CLASS"):
continue
with pytest.raises(TypeError):
clarify_model_monitor_cls.attach(SCHEDULE_NAME, sagemaker_session)

Expand Down