Skip to content

remove --strip-component for untar source tar.gz #5163

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 12, 2025
Merged

remove --strip-component for untar source tar.gz #5163

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
0b55e09
remove --strip-component for untar source tar.gz
mollyheamazon May 8, 2025
724e9d8
Merge branch 'master' into master
benieric May 9, 2025
0a0a601
Merge branch 'aws:master' into master
mollyheamazon May 9, 2025
9a691b5
update code.tar.gz in test
mollyheamazon May 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/sagemaker/modules/train/model_trainer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -865,7 +865,7 @@ def _prepare_train_script(
working_dir = f"cd {SM_CODE_CONTAINER_PATH} \n"
if source_code.source_dir.endswith(".tar.gz"):
tarfile_name = os.path.basename(source_code.source_dir)
working_dir += f"tar --strip-components=1 -xzf {tarfile_name} \n"
working_dir += f"tar -xzf {tarfile_name} \n"

if base_command:
execute_driver = EXECUTE_BASE_COMMANDS.format(base_command=base_command)
Expand Down
Binary file modified tests/data/modules/script_mode/code.tar.gz
View file
Open in desktop
Copy link
Contributor

@benieric benieric May 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this just updating or removing? Also is there already an integ for this?

Binary file not shown.