Skip to content

change: Add image configs and region config for TPE (ap-east-2) #5167

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
May 15, 2025
Merged

change: Add image configs and region config for TPE (ap-east-2) #5167

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
b20b591
add image configs and region config for TPE (ap-east-2)
May 9, 2025
cd45546
Merge branch 'master' into master
IshaChid76 May 12, 2025
05d8b20
remove TPE from djl-neuronx
May 12, 2025
619aaa1
Merge branch 'master' into master
IshaChid76 May 12, 2025
6deeeab
Merge branch 'master' into master
IshaChid76 May 13, 2025
5c3af70
Merge branch 'master' into master
pintaoz-aws May 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions src/sagemaker/image_uri_config/djl-neuronx.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@
"versions": {
"0.29.0": {
"registries": {
"ap-east-2": "975050140332",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are we sure neuronx is regionalized here? We had this issue before where we are adding regions that don't contain the images

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be fixed in the regionalizer, otherwise this will block new regions.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neuronx has a specific regionalization process that we own. We own the region list that neuronx will be regionalized to. If that did not update, we should not update this as customers would expect the image to be in that region when it isn't

"ap-northeast-1": "763104351884",
"ap-south-1": "763104351884",
"ap-southeast-1": "763104351884",
Expand All @@ -34,6 +35,7 @@
},
"0.28.0": {
"registries": {
"ap-east-2": "975050140332",
"ap-northeast-1": "763104351884",
"ap-south-1": "763104351884",
"ap-southeast-1": "763104351884",
Expand All @@ -60,6 +62,7 @@
},
"0.27.0": {
"registries": {
"ap-east-2": "975050140332",
"ap-northeast-1": "763104351884",
"ap-south-1": "763104351884",
"ap-southeast-1": "763104351884",
Expand All @@ -86,6 +89,7 @@
},
"0.26.0": {
"registries": {
"ap-east-2": "975050140332",
"ap-northeast-1": "763104351884",
"ap-south-1": "763104351884",
"ap-southeast-1": "763104351884",
Expand All @@ -112,6 +116,7 @@
},
"0.25.0": {
"registries": {
"ap-east-2": "975050140332",
"ap-northeast-1": "763104351884",
"ap-south-1": "763104351884",
"ap-southeast-1": "763104351884",
Expand All @@ -138,6 +143,7 @@
},
"0.24.0": {
"registries": {
"ap-east-2": "975050140332",
"ap-northeast-1": "763104351884",
"ap-south-1": "763104351884",
"ap-southeast-1": "763104351884",
Expand All @@ -164,6 +170,7 @@
},
"0.23.0": {
"registries": {
"ap-east-2": "975050140332",
"ap-northeast-1": "763104351884",
"ap-south-1": "763104351884",
"ap-southeast-1": "763104351884",
Expand All @@ -190,6 +197,7 @@
},
"0.22.1": {
"registries": {
"ap-east-2": "975050140332",
"ap-northeast-1": "763104351884",
"ap-south-1": "763104351884",
"ap-southeast-1": "763104351884",
Expand Down
1 change: 1 addition & 0 deletions src/sagemaker/image_uri_config/huggingface-neuron.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@
],
"repository": "huggingface-pytorch-inference-neuron",
"registries": {
"ap-east-2": "975050140332",
"ap-northeast-1": "763104351884",
"ap-south-1": "763104351884",
"ap-south-2": "772153158452",
Expand Down
7 changes: 7 additions & 0 deletions src/sagemaker/image_uri_config/huggingface-neuronx.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@
],
"repository": "huggingface-pytorch-training-neuronx",
"registries": {
"ap-east-2": "975050140332",
"ap-northeast-1": "763104351884",
"ap-south-1": "763104351884",
"ap-south-2": "772153158452",
Expand Down Expand Up @@ -62,6 +63,7 @@
],
"repository": "huggingface-pytorch-inference-neuronx",
"registries": {
"ap-east-2": "975050140332",
"ap-northeast-1": "763104351884",
"ap-south-1": "763104351884",
"ap-south-2": "772153158452",
Expand Down Expand Up @@ -105,6 +107,7 @@
],
"repository": "huggingface-pytorch-inference-neuronx",
"registries": {
"ap-east-2": "975050140332",
"ap-northeast-1": "763104351884",
"ap-south-1": "763104351884",
"ap-south-2": "772153158452",
Expand Down Expand Up @@ -163,6 +166,7 @@
"af-south-1": "626614931356",
"il-central-1": "780543022126",
"ap-east-1": "871362719292",
"ap-east-2": "975050140332",
"ap-northeast-1": "763104351884",
"ap-northeast-2": "763104351884",
"ap-northeast-3": "364406365360",
Expand Down Expand Up @@ -218,6 +222,7 @@
"af-south-1": "626614931356",
"il-central-1": "780543022126",
"ap-east-1": "871362719292",
"ap-east-2": "975050140332",
"ap-northeast-1": "763104351884",
"ap-northeast-2": "763104351884",
"ap-northeast-3": "364406365360",
Expand Down Expand Up @@ -274,6 +279,7 @@
"af-south-1": "626614931356",
"il-central-1": "780543022126",
"ap-east-1": "871362719292",
"ap-east-2": "975050140332",
"ap-northeast-1": "763104351884",
"ap-northeast-2": "763104351884",
"ap-northeast-3": "364406365360",
Expand Down Expand Up @@ -324,6 +330,7 @@
"af-south-1": "626614931356",
"il-central-1": "780543022126",
"ap-east-1": "871362719292",
"ap-east-2": "975050140332",
"ap-northeast-1": "763104351884",
"ap-northeast-2": "763104351884",
"ap-northeast-3": "364406365360",
Expand Down
3 changes: 3 additions & 0 deletions src/sagemaker/image_uri_config/huggingface-training-compiler.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,6 +60,7 @@
"af-south-1": "626614931356",
"il-central-1": "780543022126",
"ap-east-1": "871362719292",
"ap-east-2": "975050140332",
"ap-northeast-1": "763104351884",
"ap-northeast-2": "763104351884",
"ap-northeast-3": "364406365360",
Expand Down Expand Up @@ -103,6 +104,7 @@
"af-south-1": "626614931356",
"il-central-1": "780543022126",
"ap-east-1": "871362719292",
"ap-east-2": "975050140332",
"ap-northeast-1": "763104351884",
"ap-northeast-2": "763104351884",
"ap-northeast-3": "364406365360",
Expand Down Expand Up @@ -151,6 +153,7 @@
"af-south-1": "626614931356",
"il-central-1": "780543022126",
"ap-east-1": "871362719292",
"ap-east-2": "975050140332",
"ap-northeast-1": "763104351884",
"ap-northeast-2": "763104351884",
"ap-northeast-3": "364406365360",
Expand Down
4 changes: 4 additions & 0 deletions src/sagemaker/jumpstart/region_config.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,10 @@
"content_bucket": "jumpstart-cache-prod-ap-east-1",
"gated_content_bucket": "jumpstart-private-cache-prod-ap-east-1"
},
"ap-east-2": {
"content_bucket": "jumpstart-cache-prod-ap-east-2",
"gated_content_bucket": "jumpstart-private-cache-prod-ap-east-2"
},
"ap-northeast-1": {
"content_bucket": "jumpstart-cache-prod-ap-northeast-1",
"gated_content_bucket": "jumpstart-private-cache-prod-ap-northeast-1",
Expand Down