-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Add numpy 2.0 support #5199
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add numpy 2.0 support #5199
Conversation
|
Please, PLEASE get this in production ASAP! We are a lot of ML-guys waiting for it :) |
|
Is it just the few failing integration tests left to fix up? I'd offer to help fix them but it's a little hard to see why they are failing from the output. |
|
Happy to help if needed. Would love to have numpy 2.x support |
|
Our ML team also hanging on this! Any required help we can support. |
|
Hey there, is this PR getting merged soon, seeing that NumPy v1 EoL is approaching in a month (https://endoflife.date/numpy)? |
|
If someone can digest/understand where it the last unittest fails, then i'm certain that a lot of people would be able (and want) to help fixing that. But it is a bit difficult to see what the issue is tbh |
|
Can we please prioritise getting this merged ASAP? As @wickeat mentioned, NumPy 1.x reaches EOL now in less than a week, and this issue has 50+ upvotes. Would it be possible to update the packaged images to pass the failures for numpy 2.0? Happy to help assist in debugging the specific integration issues if we can get more detailed error logs from the failing tests. |
|
It looks like all integration testing passed, and this was merged into the main branch - would you mind confirming the timeline / next steps here: #4882 It looks like you changed the numpy constraint from being pinned exactly to version 1.26.4 using ==1.26.4, to now supporting a range from 1.26.4 up to (but not including) 2.3.3 using >=1.26.4,<2.3.3, which includes numpy 2.x versions. Can you confirm you have fixed the dependency issues and all the updates to other packages (scipy, pandas, scikit-learn, tensorflow, etc.) are correct and working as intended? |
Issue #, if available:
#4882
Description of changes:
Testing done:
Merge Checklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.General
Tests
unique_name_from_baseto create resource names in integ tests (if appropriate)By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.