-
Notifications
You must be signed in to change notification settings - Fork 1.2k
fix: sanitize git clone repo input url #5234
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5234 +/- ##
==========================================
- Coverage 86.08% 86.08% -0.01%
==========================================
Files 449 449
Lines 43623 43656 +33
==========================================
+ Hits 37555 37580 +25
- Misses 6068 6076 +8 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
import six | ||
from six.moves import urllib | ||
|
||
|
||
def _sanitize_git_url(repo_url): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there any sanitization happening here or is this just validation ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It shouldn't fix anything on the user's behalf so I think validation is a better word
Issue #, if available:
Description of changes:
Testing done:
Merge Checklist
Put an
x
in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.General
Tests
unique_name_from_base
to create resource names in integ tests (if appropriate)By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.