feature: AWS Batch for SageMaker Training jobs #5249
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
--------- Co-authored-by: haoxinwa <[email protected]> Co-authored-by: JennaZhao <[email protected]> Co-authored-by: Jessica Zhu <[email protected]> Co-authored-by: Erick Benitez-Ramos <[email protected]> Co-authored-by: Greg Katkov <[email protected]> Co-authored-by: David Lindskog <[email protected]>
nargokul
reviewed
Jul 30, 2025
|
|
||
| def submit( | ||
| self, | ||
| training_job: Union[EstimatorBase, ModelTrainer], |
There was a problem hiding this comment.
Do we need to also include TrainingJob from sagemaker_core here ?
There was a problem hiding this comment.
Wasn't in the scope but maybe could be added later?
Comment on lines
+2549
to
+2553
| @classmethod | ||
| def get_train_args(cls, estimator, inputs, experiment_config): | ||
| """A public function which is same as _get_train_args function.""" | ||
| return cls._get_train_args(estimator, inputs, experiment_config) | ||
|
|
There was a problem hiding this comment.
Nit: We might as well make the other function public
There was a problem hiding this comment.
The only problem with that is that that would be breaking to make other function public. Estimator is much older interface with higher usage, so risk of breaking is higher
nargokul
approved these changes
Jul 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
AWS Batch for SageMaker Training jobs
Testing done:
Merge Checklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.General
Tests
unique_name_from_baseto create resource names in integ tests (if appropriate)By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.