Skip to content

Conversation

cuongvd23
Copy link

@cuongvd23 cuongvd23 commented Aug 25, 2025

Issue #, if available:
#5262

Description of changes:
Change S3_ENDPOINT_URL_ENV_NAME from S3_ENDPOINT_URL to AWS_ENDPOINT_URL_S3

References:

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

  • I have read the CONTRIBUTING doc
  • I certify that the changes I am introducing will be backward compatible, and I have discussed concerns about this, if any, with the Python SDK team
  • I used the commit message format described in CONTRIBUTING
  • I have passed the region in to all S3 and STS clients that I've initialized as part of this change.
  • I have updated any necessary documentation, including READMEs and API docs (if appropriate)

Tests

  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have added unit and/or integration tests as appropriate to ensure backward compatibility of the changes
  • I have checked that my tests are not configured for a specific region or account (if appropriate)
  • I have used unique_name_from_base to create resource names in integ tests (if appropriate)
  • If adding any dependency in requirements.txt files, I have spell checked and ensured they exist in PyPi

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@cuongvd23 cuongvd23 force-pushed the cuongvd/local-mode-s3-endpoint-env branch from d5397cb to 249a5f1 Compare August 30, 2025 09:43
@cuongvd23 cuongvd23 marked this pull request as ready for review August 30, 2025 16:50
@cuongvd23 cuongvd23 requested a review from a team as a code owner August 30, 2025 16:50
@cuongvd23 cuongvd23 requested a review from chad119 August 30, 2025 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant