Skip to content

Conversation

@wutimot
Copy link
Collaborator

@wutimot wutimot commented Sep 17, 2025

Issue #, if available:

Description of changes: EMR Step in the backend was using a retryable step, whereas the sagemaker python sdk EMR Step was not, thus it wasn't possible to configure retries on EMR steps. This fix addresses this gap by making the EMR step use retryable in sdk.

Testing done: Added unit and integration tests with the new optional parameter, and ran both
tox -e py310 -- -s -vv tests/integ/sagemaker/workflow/test_emr_steps.py
tox -e py310 -- -s -vv tests/unit/sagemaker/workflow/test_emr_step.py with all passing, as well as the old unit tests passing which shows backward compatibility

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

  • [ x] I have read the CONTRIBUTING doc
  • [x ] I certify that the changes I am introducing will be backward compatible, and I have discussed concerns about this, if any, with the Python SDK team
  • [x ] I used the commit message format described in CONTRIBUTING
  • I have passed the region in to all S3 and STS clients that I've initialized as part of this change.
  • I have updated any necessary documentation, including READMEs and API docs (if appropriate)

Tests

  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have added unit and/or integration tests as appropriate to ensure backward compatibility of the changes
  • I have checked that my tests are not configured for a specific region or account (if appropriate)
  • I have used unique_name_from_base to create resource names in integ tests (if appropriate)
  • If adding any dependency in requirements.txt files, I have spell checked and ensured they exist in PyPi

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@wutimot wutimot requested a review from a team as a code owner September 17, 2025 08:59
@wutimot wutimot marked this pull request as draft September 17, 2025 09:08
@wutimot wutimot closed this Sep 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant