fix: add retryable option to emr step in SageMaker Pipelines #5280
+550
−5
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes: EMR Step in the backend was using a retryable step, whereas the sagemaker python sdk EMR Step was not, thus it wasn't possible to configure retries on EMR steps. This fix addresses this gap by making the EMR step use retryable in sdk.
Testing done: Added unit and integration tests with the new optional parameter, and ran both
tox -e py310 -- -s -vv tests/integ/sagemaker/workflow/test_emr_steps.py
tox -e py310 -- -s -vv tests/unit/sagemaker/workflow/test_emr_step.py with all passing, as well as the old unit tests passing which shows backward compatibility
Merge Checklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.General
Tests
unique_name_from_baseto create resource names in integ tests (if appropriate)By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.