Skip to content

Conversation

@nargokul
Copy link
Contributor

@nargokul nargokul commented Oct 13, 2025

Issue #, if available:

Updates regex patterns across the SDK to support instance types with hyphens in family names (e.g., ml.p6-b200.48xlarge).
Previously, instance type validation would fail for newer instance families that include hyphens.
Modified patterns in utils.py, fw_utils.py, estimator.py, and optimize_utils.py to include - in character classes.
Added comprehensive test coverage for hyphenated instance types across all affected modules.

https://tiny.amazon.com/1kno4b1e

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

  • I have read the CONTRIBUTING doc
  • I certify that the changes I am introducing will be backward compatible, and I have discussed concerns about this, if any, with the Python SDK team
  • I used the commit message format described in CONTRIBUTING
  • I have passed the region in to all S3 and STS clients that I've initialized as part of this change.
  • I have updated any necessary documentation, including READMEs and API docs (if appropriate)

Tests

  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have added unit and/or integration tests as appropriate to ensure backward compatibility of the changes
  • I have checked that my tests are not configured for a specific region or account (if appropriate)
  • I have used unique_name_from_base to create resource names in integ tests (if appropriate)
  • If adding any dependency in requirements.txt files, I have spell checked and ensured they exist in PyPi

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@nargokul nargokul requested a review from a team as a code owner October 13, 2025 22:50
@nargokul nargokul requested a review from rsareddy0329 October 13, 2025 22:50
@nargokul nargokul merged commit 824675b into aws:master Oct 14, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants