-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Add Numpy 2.0 support #5311
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Numpy 2.0 support #5311
Conversation
| @@ -1,5 +1,5 @@ | |||
| tox==3.24.5 | |||
| numpy==1.26.4 | |||
| numpy>=2.0.0, <3.0 | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not sure if this is supposed to same as pyproject.toml: "numpy>=1.26.4,<3.0", not a hard blocker but we need to synchronize our dependencies.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Comments for followup, no hard blockers on this PR.
| - pip: | ||
| - mlflow==2.11.1 | ||
| - cloudpickle==2.2.1 | ||
| - numpy==1.26.4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are we needing to support both? is there a path forward for having a singular dependency closure supported? or else we will have to support this each time.
|
Thank you all! 🙏 This will be very helpful for users trying to get access to the latest fixes and features in NumPy 2.0 😀 |
Issue #, if available:
Description of changes:
Testing done:
Merge Checklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.General
Tests
unique_name_from_baseto create resource names in integ tests (if appropriate)By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.