Skip to content

Conversation

@rsareddy0329
Copy link
Contributor

Issue #, if available:

Description of changes:

Testing done:

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

  • I have read the CONTRIBUTING doc
  • I certify that the changes I am introducing will be backward compatible, and I have discussed concerns about this, if any, with the Python SDK team
  • I used the commit message format described in CONTRIBUTING
  • I have passed the region in to all S3 and STS clients that I've initialized as part of this change.
  • I have updated any necessary documentation, including READMEs and API docs (if appropriate)

Tests

  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have added unit and/or integration tests as appropriate to ensure backward compatibility of the changes
  • I have checked that my tests are not configured for a specific region or account (if appropriate)
  • I have used unique_name_from_base to create resource names in integ tests (if appropriate)
  • If adding any dependency in requirements.txt files, I have spell checked and ensured they exist in PyPi

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@rsareddy0329 rsareddy0329 marked this pull request as ready for review October 23, 2025 16:47
@rsareddy0329 rsareddy0329 requested a review from a team as a code owner October 23, 2025 16:47
@@ -1,5 +1,5 @@
tox==3.24.5
numpy==1.26.4
numpy>=2.0.0, <3.0
Copy link
Member

@mufaddal-rohawala mufaddal-rohawala Oct 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure if this is supposed to same as pyproject.toml: "numpy>=1.26.4,<3.0", not a hard blocker but we need to synchronize our dependencies.

Copy link
Member

@mufaddal-rohawala mufaddal-rohawala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comments for followup, no hard blockers on this PR.

- pip:
- mlflow==2.11.1
- cloudpickle==2.2.1
- numpy==1.26.4
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we needing to support both? is there a path forward for having a singular dependency closure supported? or else we will have to support this each time.

@rsareddy0329 rsareddy0329 changed the title Numpy 2.0 testing Add Numpy 2.0 support Oct 28, 2025
@rsareddy0329 rsareddy0329 merged commit 99210b2 into aws:master Oct 28, 2025
13 of 14 checks passed
@jakirkham
Copy link

Thank you all! 🙏

This will be very helpful for users trying to get access to the latest fixes and features in NumPy 2.0 😀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants