feat: add introspection, query & resolver limits properties in appsync graphql api #3668
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Hi @GavinZZ can you help or give direction on getting this PR reviewed and merged, as we need this attributes support for security compliance |
godwingrs22
approved these changes
Oct 29, 2024
Member
godwingrs22
left a comment
godwingrs22
left a comment
There was a problem hiding this comment.
Thanks @vaibhav170 for the contribution. LGTM
godwingrs22
changed the title
GavinZZ
requested changes
Oct 29, 2024
Member
GavinZZ
left a comment
GavinZZ
left a comment
There was a problem hiding this comment.
Changes look good, are you able to add an integration test case for these properties to test the deployability?
Contributor
Author
hi @GavinZZ added integration test for Introspection configuration |
GavinZZ
approved these changes
Oct 30, 2024
Member
|
Thank you for contributing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #3666
Description of changes
Adding new fields AppSync has added to CFN.
IntrospectionConfig
ResolverCountLimit
QueryDepthLimit
Description of how you validated changes
this three are pass through properties, tested output of bin/add_transform_test.py script by deploying it using cloudformation, working as expected
Checklist
Examples?
Please reach out in the comments if you want to add an example. Examples will be
added to
sam initthrough aws/aws-sam-cli-app-templates.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.