-
Notifications
You must be signed in to change notification settings - Fork 755
add pages to contribute chapter #844
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 7 commits
2115295
28a28e6
3f15b26
5f87629
693c4fb
42f2ec5
cde29d3
0c1b004
d33769e
68034fd
437000b
c38d372
2a2044b
d22b490
d6b4a3d
6051767
e12e538
d77ec78
8c2e3ac
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,49 @@ | ||
| [.topic] | ||
| [#create-content-q] | ||
| = Create docs content with Amazon Q | ||
|
Check notice on line 3 in latest/ug/contribute/create-content-q.adoc
|
||
| :info_titleabbrev: Create with Amazon Q | ||
|
|
||
| You can use Amazon Q to create and revise docs content. This is an easy way to get started on a new page. Amazon Q is available as an extension to Visual Studio (VS) Code. | ||
|
Check warning on line 6 in latest/ug/contribute/create-content-q.adoc
|
||
|
|
||
| In the following image, Amazon Q generated the lines marked with green. | ||
|
Check warning on line 8 in latest/ug/contribute/create-content-q.adoc
|
||
|
|
||
| image::images/contribute-q.png["Amazon Q in VS Code"] | ||
|
Check warning on line 10 in latest/ug/contribute/create-content-q.adoc
|
||
|
|
||
| == Install Amazon Q with VS Code | ||
|
Check notice on line 12 in latest/ug/contribute/create-content-q.adoc
|
||
|
|
||
| 1. Open VS Code | ||
|
Check notice on line 14 in latest/ug/contribute/create-content-q.adoc
|
||
| 2. Go to the Extensions view (Ctrl+Shift+X or Cmd+Shift+X) | ||
| 3. Search for "Amazon Q" | ||
| 4. Click Install on the Amazon Q extension | ||
| 5. Wait for installation to complete | ||
| 6. Restart VS Code when prompted | ||
|
Check notice on line 19 in latest/ug/contribute/create-content-q.adoc
|
||
|
|
||
| == Login to Amazon Q | ||
|
Check notice on line 21 in latest/ug/contribute/create-content-q.adoc
|
||
|
|
||
| 1. After installing, click the Amazon Q icon in the VS Code activity bar | ||
|
Check notice on line 23 in latest/ug/contribute/create-content-q.adoc
|
||
| 2. Click "Sign in to Amazon Q" | ||
| 3. Enter your {aws} credentials when prompted | ||
| 4. Once authenticated, you'll see the Amazon Q chat interface | ||
|
|
||
| == Use Amazon Q to create content | ||
|
Check notice on line 28 in latest/ug/contribute/create-content-q.adoc
|
||
|
|
||
| 1. Open the file you want to edit in VS Code | ||
|
Check warning on line 30 in latest/ug/contribute/create-content-q.adoc
|
||
| 2. Select the text you want to revise or the location for new content | ||
| 3. Press *Ctrl+I* or *Cmd+I* | ||
|
Check warning on line 32 in latest/ug/contribute/create-content-q.adoc
|
||
| 4. In the prompt, be specific about: | ||
| * The type of content you need | ||
| * The target audience | ||
| * Key points to cover | ||
| * Desired tone and style | ||
|
Check warning on line 37 in latest/ug/contribute/create-content-q.adoc
|
||
| 5. Review the generated content in the inline preview | ||
| 6. Use *enter* to accept the changes, or *esc* to reject them. | ||
|
Check warning on line 39 in latest/ug/contribute/create-content-q.adoc
|
||
| 7. Edit further as needed | ||
|
|
||
| == Tips | ||
|
|
||
| * Start with a simple request and iterate to get the content you want. | ||
| * Create a first draft of the page headings, then ask Q to fill them in. | ||
| * Amazon Q may output Markdown. This is fine. The AsciiDoc tooling can understand most markdown syntax. | ||
|
Check warning on line 46 in latest/ug/contribute/create-content-q.adoc
|
||
|
|
||
| To learn more about Amazon Q Developer, see link:amazonq/latest/qdeveloper-ug/q-in-IDE.html["Using Amazon Q Developer in the IDE",type="documentation"]. | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,35 @@ | ||
| [.topic] | ||
| [#create-page] | ||
| = Create a new page | ||
| :info_titleabbrev: Create page | ||
|
|
||
|
|
||
| Learn how to create a new docs page. This topic includes instructions for creating the initial page metadata, and adding the page to the guide table of contents. | ||
|
Check notice on line 7 in latest/ug/contribute/create-page.adoc
|
||
|
|
||
| == Create page | ||
|
|
||
| . Navigate to the chapter directory. For example, if you want to create a new page in the "Security" section, navigate to the `latest/ug/security` directory. | ||
| . Determine the page ID. By convention, the page ID is all lowercase and seperated with `-`. The ID of this page is `create-page`. | ||
|
Check notice on line 12 in latest/ug/contribute/create-page.adoc
|
||
| . Create a new file with the page ID and the `adoc` extension. For example, `create-page.adoc`. | ||
| . Insert the page metadata using this template: | ||
|
|
||
| image::images/contribute-new-page.png["New page metadata"] | ||
|
|
||
|
|
||
| == Add page to navigation | ||
|
|
||
| . Navigate to the parent page. The parent page of top level sections is `book.adoc`. | ||
| . At the bottom of the parent page, include the child page. | ||
| + | ||
| [source] | ||
| ==== | ||
| +++include::${filename}[leveloffset=+1]+++ | ||
| ==== | ||
| + | ||
| _For example:_ | ||
| + | ||
| [source] | ||
| ==== | ||
| +++include::create-page.adoc[leveloffset=+1]+++ | ||
| ==== | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,59 @@ | ||
| [.topic] | ||
| [#edit-single-web] | ||
| = Edit a single page from a web browser | ||
| :info_titleabbrev: Edit single page | ||
|
|
||
| You can easily edit a single page in the EKS User Guide directly through your web browser. | ||
|
|
||
| image::images/contribute-web-edit.png["View of GitHub web edit interface"] | ||
|
|
||
| If you want to edit multiple pages from your web browser, see <<edit-web>>. | ||
|
Check notice on line 10 in latest/ug/contribute/edit-single-web.adoc
|
||
|
|
||
| == Prerequisites | ||
|
|
||
| * Docs page to change opened in web browser | ||
| * Signed into GitHub | ||
|
|
||
| == Procedure | ||
|
|
||
| . Navigate to the page you want to edit in the EKS User Guide documentation | ||
|
|
||
| . Look for the *Edit this page on GitHub* button located in the right sidebar of the page | ||
|
|
||
| . Once on GitHub, open the editor by either: | ||
| ** Pressing the `e` key on your keyboard | ||
| ** Clicking the pencil icon and selecting *Edit in Place* from the dropdown menu | ||
| ** If you don't have the option to edit, you need to login to GitHub. Your GitHub account does not need any special permissions to suggest changes. However, internal Amazon contributors should link their GitHub profile. | ||
|
Check notice on line 26 in latest/ug/contribute/edit-single-web.adoc
|
||
|
|
||
| . Make your desired changes to the content in the GitHub editor | ||
|
Check warning on line 28 in latest/ug/contribute/edit-single-web.adoc
|
||
| ** The editor provides syntax highlighting and preview capabilities | ||
| ** You can use AsciiDoc markup to format your changes | ||
| ** You can use `ctrl-f` to open a find/replace interface. | ||
|
|
||
| . (Optional) Preview your changes. | ||
| ** Use the `preview` tab to preview your changes with rich formatting. | ||
| ** Use the `show diff` option to highlight changed sections. Removed sections have a red indicator in the left margin. New sections have a green indicator in the left margin. | ||
|
Check warning on line 35 in latest/ug/contribute/edit-single-web.adoc
|
||
|
|
||
| . When finished editing, click the *Commit changes...* button at the top of the editor | ||
|
|
||
| . In the commit dialog: | ||
| ** Verify your email address is correct | ||
|
Check notice on line 40 in latest/ug/contribute/edit-single-web.adoc
|
||
| ** Add a brief but descriptive commit message explaining your changes | ||
| ** Optionally add a longer description if needed | ||
| ** Select to create a new branch and pull request | ||
|
|
||
| You have created a pull request including the proposed changes. | ||
|
|
||
| == Pull Request Overview | ||
|
Check notice on line 47 in latest/ug/contribute/edit-single-web.adoc
|
||
|
|
||
| When you create a PR: | ||
|
|
||
| * Your changes are submitted for review by repository maintainers | ||
|
Check notice on line 51 in latest/ug/contribute/edit-single-web.adoc
|
||
| * Reviewers can comment on your changes and request modifications | ||
| * Automated tests may run to validate your changes | ||
|
Check warning on line 53 in latest/ug/contribute/edit-single-web.adoc
|
||
| * Once approved, your changes can be merged into the main repository | ||
|
Check notice on line 54 in latest/ug/contribute/edit-single-web.adoc
|
||
|
|
||
| Pull requests help ensure quality and provide a way to discuss changes before they are integrated. | ||
|
Check notice on line 56 in latest/ug/contribute/edit-single-web.adoc
|
||
|
|
||
| https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/about-pull-request-reviews[Learn how pull requests are reviewed and approved in the GitHub Docs.] | ||
|
Check notice on line 58 in latest/ug/contribute/edit-single-web.adoc
|
||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,31 @@ | ||
| [.topic] | ||
| [#edit-web] | ||
| = Edit multiple files from a web browser with the GitHub Web Editor | ||
|
Check notice on line 3 in latest/ug/contribute/edit-web.adoc
|
||
| :info_titleabbrev: Edit files with GitHub | ||
|
|
||
| If you want to propose change to multiple pages, or create a new docs page, use the GitHub.dev web editor. This web editor is based on the popular Visual Studio Code text editor. | ||
|
Check notice on line 6 in latest/ug/contribute/edit-web.adoc
|
||
|
|
||
| image::images/contribute-web-dev.png["GitHub.dev web editor user interface] | ||
|
|
||
| == Prerequisites | ||
|
|
||
| * Logged in to GitHub | ||
| * Familiarity with Visual Studio Code editor | ||
| * Familiarity with Git | ||
|
|
||
| == Procedure | ||
|
|
||
| NOTE: The EKS Docs team has created a workspace file that includes suggested configurations for the editor, such as text wrapping and AsciiDoc syntax highlighting. We suggest you load this workspace file. | ||
|
|
||
| . Open the https://github.dev/awsdocs/amazon-eks-user-guide/blob/mainline/eks-docs.code-workspace?workspace=true[workspace] on GitHub.dev | ||
|
Check failure on line 20 in latest/ug/contribute/edit-web.adoc
|
||
| ** You can bookmarl the URL `https://github.dev/awsdocs/amazon-eks-user-guide/blob/mainline/eks-docs.code-workspace?workspace=true` | ||
|
Check warning on line 21 in latest/ug/contribute/edit-web.adoc
|
||
| . (First time setup only) You may be propted to create a fork of the repo in your own GitHub account. Accept this prompt. For more information, see https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/about-forks[About forks] in the GitHub docs. | ||
|
Check warning on line 22 in latest/ug/contribute/edit-web.adoc
|
||
| . (First time setup only) Accept the prompt in the bottom right to install the AsciiDoc extension. | ||
|
Check warning on line 23 in latest/ug/contribute/edit-web.adoc
|
||
| . Navigate to the docs content at `latest/ug` | ||
| ** Docs files are organized by their top level section. For example, pages in the "Security" chapter have source files under the "security/" directory. | ||
|
Check notice on line 25 in latest/ug/contribute/edit-web.adoc
|
||
| . To view a preview of a docs page, use the *Open preview to the Side* button in the top right. The icon includes a small magnifying glass. | ||
| . Use the *Source Control* tab in the left to commit your changes. For more information, see the Visual Studio Code docs: | ||
| ** https://code.visualstudio.com/docs/sourcecontrol/overview#_commit[Commit changes] | ||
| ** https://code.visualstudio.com/docs/sourcecontrol/github#_creating-pull-requests[Create a pull request] | ||
|
|
||
| After you create a pull request, it will be reviewed by the docs team. | ||
|
Check notice on line 31 in latest/ug/contribute/edit-web.adoc
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| ../images |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,33 @@ | ||
| [.topic] | ||
| [#insert-link] | ||
| = Insert a link | ||
| :info_titleabbrev: Insert link | ||
|
|
||
| AsciiDoc supports multiple types of links. Using the right link type is important so the link works properly in different environments. | ||
|
Check notice on line 6 in latest/ug/contribute/insert-link.adoc
|
||
|
|
||
| == Link to a page or section in the EKS User Guide | ||
|
|
||
| Use cross references (xref) to link between pages/sections within the same documentation site, such as the EKS User Guide. They automatically update if the target section moves or is renamed. | ||
|
Check warning on line 10 in latest/ug/contribute/insert-link.adoc
|
||
|
|
||
| === Define custom link text | ||
|
|
||
| `xref` `:section-id[${link-text}]` | ||
|
|
||
| === Use page title as link text | ||
|
|
||
| Use the section ID surrounded by angle brackets. For example `<<` `page-id>>`. | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Use the section ID surrounded by angle brackets. For example |
||
|
|
||
| == Link to another page in the {aws} Docs | ||
|
|
||
| . Find the link to the {aws} Docs page | ||
| . Remove the `https://docs.aws.amazon.com/` prefix, keeping only the path. The path should start with an a-z character. | ||
| . Create a link as shown below | ||
|
|
||
| `link` `:AmazonS3/latest/userguide/create-bucket-overview.html["Create a bucket", type="documentation"]` | ||
|
|
||
| == Link out to the internet | ||
|
|
||
| This format creates a standard link out to the internet. Use this for Non-Amazon content or content on GitHub. | ||
|
|
||
| `link` `:https://example.com[Visit Example Site]` | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,40 @@ | ||
| [.topic] | ||
| [#pr-preview] | ||
| = View a preview of pull request content | ||
| :info_titleabbrev: View PR Preview | ||
|
|
||
| The EKS User Guide GitHub is configured to build and generate a preview of the docs site. This preview doesn't have the full {aws} theme, but it does check the content builds properly and links work. | ||
|
Check notice on line 6 in latest/ug/contribute/pr-preview.adoc
|
||
|
|
||
| image::images/contribute-preview.png["GitHub comment with preview URL"] | ||
|
|
||
| This preview is hosted at a temporary URL by {aws} Amplify. | ||
|
Check notice on line 10 in latest/ug/contribute/pr-preview.adoc
|
||
|
|
||
| == View Preview | ||
|
Check notice on line 12 in latest/ug/contribute/pr-preview.adoc
|
||
|
|
||
| When you submit a pull request, {aws} Amplify attemps to build and deploy a preview of the content. | ||
|
Check warning on line 14 in latest/ug/contribute/pr-preview.adoc
|
||
|
|
||
| If the build succeeds, *aws-amplify-us-east-1* comments the preview link on the pull request. | ||
|
|
||
| If the build fails, the repo admins can see the logs and provide feedback. | ||
|
Check warning on line 18 in latest/ug/contribute/pr-preview.adoc
|
||
|
|
||
| NOTE: If you haven't contributed before, a project maintainer may need to approve running the build. | ||
|
Check notice on line 20 in latest/ug/contribute/pr-preview.adoc
|
||
|
|
||
| == Preview limitations | ||
|
|
||
| The preview is built as a single large HTML file. It will be displayed as multiple pages when published. | ||
|
Check notice on line 24 in latest/ug/contribute/pr-preview.adoc
|
||
|
|
||
| *What works:* | ||
|
|
||
| * Cross references (`xref`) | ||
| * Links to the internet | ||
| * Images | ||
| * Content hosted from `samples/` | ||
|
|
||
| *What doesn't work:* | ||
|
Check notice on line 33 in latest/ug/contribute/pr-preview.adoc
|
||
|
|
||
| * Links to other {aws} content, links with `type="documentation"`. | ||
| ** This content doesn't exist in the preview environment. | ||
|
Check notice on line 36 in latest/ug/contribute/pr-preview.adoc
|
||
| * The variable `aws` will not display properly. The value of this changes based on the environment. | ||
|
|
||
|
|
||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,75 @@ | ||
| [.topic] | ||
| [#pr-status] | ||
| = View the status of your GitHub Pull Request (PR) | ||
|
Check notice on line 3 in latest/ug/contribute/pr-status.adoc
|
||
| :info_titleabbrev: View PR Status | ||
|
|
||
| After you create a pull request, you can track it's status. Pull requests have three important statuses: merged, closed, and changes requested. | ||
|
Check notice on line 6 in latest/ug/contribute/pr-status.adoc
|
||
|
|
||
| If a pull request is merged, the changes were accepted. It may take a few hours for the website to update. If the PR was closed, please understand we appreciate the contribution but could not approve the changes. For example, we may have been unable to replicate the problem. If a pull request has changes requested, review the feedback and update the pull request. | ||
|
Check notice on line 8 in latest/ug/contribute/pr-status.adoc
|
||
|
|
||
| include::images/contribute-pr.png["View PR feedback"] | ||
|
|
||
| == View the pull requests you created | ||
| To view pull requests you created: | ||
|
|
||
| . Go to the GitHub repository | ||
| . Click the "Pull requests" tab | ||
| . Select *Filters* and then *Your pull requests* | ||
| . Review the list of your open pull requests | ||
|
|
||
| == View pull requests assigned to you | ||
| To view pull requests assigned to you for review: | ||
|
|
||
| . Go to the GitHub repository | ||
| . Click the "Pull requests" tab | ||
| . Select *filters* and then *assigned to you* | ||
| . Review the list of pull requests awaiting your review | ||
|
|
||
| == Review a pull request | ||
|
|
||
| Learn how to https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/reviewing-proposed-changes-in-a-pull-request[review a pull request] in the GitHub Docs. | ||
|
|
||
| == Make further changes on a pull request | ||
|
|
||
| If changes are requested on a pull request, you can make further changes in the pull request. | ||
|
Check notice on line 34 in latest/ug/contribute/pr-status.adoc
|
||
|
|
||
| {aws} suggests using the GitHub.dev web editor to make further changes to a pull request. This supports viewing PR comments inside the text editor. | ||
|
Check warning on line 36 in latest/ug/contribute/pr-status.adoc
|
||
|
|
||
| === Make further changes with a web browser | ||
|
|
||
| . Use the `.` (period) key to open the pull request in the GitHub web editor | ||
| . Review the comments and make changes in the text editor. You can mark comments as resolved from within the editor. | ||
| . Use the *source control* menu in the left sidebar to commit the changes, which updates the PR. | ||
|
|
||
| === Make further changes locally | ||
|
|
||
| Use the GitHub CLI to pull the changes locally. | ||
|
|
||
| ==== Setup GitHub CLI | ||
|
Check notice on line 48 in latest/ug/contribute/pr-status.adoc
|
||
|
|
||
| . Install the GitHub CLI if you haven't already: | ||
|
Check notice on line 50 in latest/ug/contribute/pr-status.adoc
|
||
| * For macOS: `brew install gh` | ||
| * For Windows: `winget install GitHub.cli` | ||
| * For Linux: Follow instructions at https://github.com/cli/cli#installation | ||
|
|
||
| . Authenticate with GitHub: | ||
| * Run `gh auth login` | ||
| * Follow the prompts to complete authentication | ||
|
|
||
| ==== Checkout pull request | ||
|
|
||
| . Check out the pull request branch: | ||
| * Run `gh pr checkout <PR-NUMBER>` | ||
| * Replace <PR-NUMBER> with your pull request number | ||
| * The pull request number is visible at the top of the PR | ||
| * This creates a local branch with the PR changes | ||
|
|
||
| . Make your changes locally using your preferred text editor | ||
|
|
||
| . Commit and push your changes: | ||
| * Stage changes: `git add .` | ||
| * Commit changes: `git commit -m "your commit message"` | ||
| * Push to GitHub: `git push` | ||
|
|
||
| The pull request will automatically update with your new changes. | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,26 @@ | ||
| [.topic] | ||
| [#vale-github] | ||
| = View style feedback online for a pull request | ||
| :info_titleabbrev: View PR feedback | ||
|
|
||
| When you create a pull request to propose docs changes, multiple GitHub actions run. This includes a style check using Vale. | ||
|
Check notice on line 6 in latest/ug/contribute/vale-github.adoc
|
||
|
|
||
| image::images/contribute-style-web.png["View style feedback on GitHub"] | ||
|
|
||
| The style check: | ||
|
|
||
| * Returns an error if the string "AWS" is used instead of the variable `{aws}` | ||
|
Check notice on line 12 in latest/ug/contribute/vale-github.adoc
|
||
| ** Pull requests cannot be merged until this is resolved. | ||
|
Check notice on line 13 in latest/ug/contribute/vale-github.adoc
|
||
| * Adds style comments to the pull request. | ||
|
|
||
| == View style feedback | ||
|
|
||
| . Open your Pull Request | ||
| ** https://github.com/awsdocs/amazon-eks-user-guide/pulls[View a list of open pull requests] | ||
| . Select the *Files changed* tab | ||
| . Feedback from Vale is visible as line comments, that start with `[vale]`. | ||
| ** Use the style feedback to identify typos, spelling errors, and awkward phrasing. | ||
|
|
||
| When you update a pull request, the Vale check runs again. | ||
|
|
||
| Learn how to https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/proposing-changes-to-your-work-with-pull-requests/creating-a-pull-request#making-changes-to-files-in-your-pull-request[Make changes to files in your pull request] in the GitHub docs. | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
. (First time setup only) You may be prompted to create a fork of the repo in your own GitHub account. Accept this prompt. For more information, see https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/about-forks[About forks] in the GitHub docs.