Add Pod Identity setup details for the EFS CSI driver addon #916
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically being deployed by Amplify Hosting (learn more). |
Contributor
|
Thanks for submitting @AlexKaracaoglu ! We are taking a look |
|
Hi @AlexKaracaoglu, just saw this. Please give me a 2 business days to test your changes before merging them. |
thakurmi
approved these changes
Mar 21, 2025
Contributor
Author
|
Thanks for the review @thakurmi and for the response @geoffcline! Let me know if there's anything additional you need from my end or want to chat more on this change before a potential merge |
pgasca
approved these changes
Mar 25, 2025
Contributor
pgasca
left a comment
pgasca
left a comment
There was a problem hiding this comment.
Merging PR but will do follow-up commit with style updates.
Contributor
|
Thank you @AlexKaracaoglu , here are the style updates I made on top of your PR: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: #915
Description of changes:
This change adds Pod Identity setup details to the EFS CSI driver setup guide.
Previously, the guide assumed IRSA and the prerequisite of an OIDC provider setup with the cluster.
If using Pod Identity, the setup is slightly different and this takes into account the IRSA as well as the Pod Identity setup avenues.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.