Skip to content

Conversation

@geoffcline
Copy link
Contributor

add consideration for access entries type

add consideration for access entries type
@geoffcline geoffcline requested a review from fincd-aws March 17, 2025 17:42
@aws-amplify-us-east-1
Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-924.d3rijirjvbh87e.amplifyapp.com

--policy-arn {arn-aws}iam::aws:policy/AmazonEKSVPCResourceController
----
. Create a file named [.replaceable]`vpc-resource-controller-configmap.yaml` with the following contents.
. If the VPC CNI *is not* installed as an Amazon EKS Add-on:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

VPC CNI is is always installed for networking in k8s. This command just enable Windows-ipam inside VPC resource controller.

Rephrase the statement to, enable IPAM for Windows nodes in VPC resource controller using following ConfigMap.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it matters if it's installed as a managed add-on or regular, right?

if it's a managed add-on, they need to configure the add-on

if it's regular, they can just update the config

does that make sense?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CNI for Windows is different from Linux. Windows CNI is shipped in AMIs. It is not installed via addon.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah tyty

@geoffcline geoffcline self-assigned this Mar 19, 2025
@geoffcline geoffcline merged commit f690536 into mainline Mar 31, 2025
1 check was pending
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants