-
Notifications
You must be signed in to change notification settings - Fork 755
Update windows-support.adoc with access entry considerations #924
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
add consideration for access entries type
|
This pull request is automatically being deployed by Amplify Hosting (learn more). |
| --policy-arn {arn-aws}iam::aws:policy/AmazonEKSVPCResourceController | ||
| ---- | ||
| . Create a file named [.replaceable]`vpc-resource-controller-configmap.yaml` with the following contents. | ||
| . If the VPC CNI *is not* installed as an Amazon EKS Add-on: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
VPC CNI is is always installed for networking in k8s. This command just enable Windows-ipam inside VPC resource controller.
Rephrase the statement to, enable IPAM for Windows nodes in VPC resource controller using following ConfigMap.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it matters if it's installed as a managed add-on or regular, right?
if it's a managed add-on, they need to configure the add-on
if it's regular, they can just update the config
does that make sense?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CNI for Windows is different from Linux. Windows CNI is shipped in AMIs. It is not installed via addon.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah tyty
add consideration for access entries type