Skip to content

Conversation

@DavidSouther
Copy link
Contributor

Issue #, if available: Closes #98

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@DavidSouther DavidSouther requested a review from Laren-AWS October 1, 2024 14:06
@DavidSouther DavidSouther added Enhancement A general update to the code base. Task A general update to the code base for language clarification, missing actions, tests, etc. labels Oct 1, 2024
@DavidSouther DavidSouther marked this pull request as ready for review October 1, 2024 14:06
@DavidSouther DavidSouther force-pushed the docs/release/date_based_semver branch from a7d03e0 to 04fd29f Compare October 1, 2024 14:11
@DavidSouther DavidSouther force-pushed the docs/release/date_based_semver branch from 72b2fa5 to 76cfcb9 Compare October 1, 2024 14:29
Copy link
Contributor

@Laren-AWS Laren-AWS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, I think this makes sense and should ease some of the pain.

I found a few issues while testing stamp.sh.

@DavidSouther DavidSouther requested a review from Laren-AWS October 2, 2024 14:24
@DavidSouther DavidSouther requested a review from Laren-AWS October 7, 2024 18:32
@DavidSouther DavidSouther force-pushed the docs/release/date_based_semver branch from 971dd67 to e1f3d91 Compare October 7, 2024 18:32
@DavidSouther DavidSouther self-assigned this Oct 7, 2024
@DavidSouther DavidSouther merged commit bf06155 into main Oct 7, 2024
2 checks passed
@DavidSouther DavidSouther deleted the docs/release/date_based_semver branch November 18, 2024 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Enhancement A general update to the code base. Task A general update to the code base for language clarification, missing actions, tests, etc.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Use date-based build stamps for setup.py versioning

2 participants