Skip to content

Conversation

@Laren-AWS
Copy link
Contributor

This PR adds a few things to let update-mirror correctly merge services, SDKs, and validation metadata from tributaries. With upcoming update-mirror changes, this fully enables the feature that lets tributaries define their own services.yaml, sdks.yaml, and validation.yaml.

  • Adds incremental=true to DocGen default so it does loads the default metadata from itself but does not try to load any examples. This defines the "default" DocGen as containing all of the services, SDKs, and validation lists defined in this repo so that it can be used as a basis for merging in tributary examples and additional services, SDKs, and validation.
  • Update DocGen.merge to merge validation data from other.

With these changes, update-mirror can then:

  1. Load a default DocGen.
  2. Merge metadata from a tributary and successfully validate it against the base services, etc., as well as the tributary add-ons.
  3. Merge each tributary into the full registry of metadata.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@Laren-AWS Laren-AWS requested a review from DavidSouther October 4, 2024 22:39
@Laren-AWS Laren-AWS self-assigned this Oct 4, 2024
@Laren-AWS Laren-AWS added the Enhancement A general update to the code base. label Oct 4, 2024
@DavidSouther DavidSouther merged commit 48b017d into main Oct 7, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Enhancement A general update to the code base.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants