Update stats.py #106
Closed
Update stats.py #106
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DavidSouther
requested changes
Oct 11, 2024
aws_doc_sdk_examples_tools/stats.py
Outdated
| print(f"GenAI {genai}") | ||
| stats['root'] = docgen_root.name | ||
| all_stats.append(stats) | ||
| return all_stats |
Contributor
There was a problem hiding this comment.
Why are you returning a list from a main? What's the goal for this change?
Contributor
Author
There was a problem hiding this comment.
I want stats.py to return the stats, so it can be used like this: stats = doc_gen.stats(). Happy to create a separate method to implement this if that makes you more comfortable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes it so this module returns a stats object instead of nothing at all.