Skip to content

Conversation

@Laren-AWS
Copy link
Contributor

@Laren-AWS Laren-AWS commented Dec 2, 2024

Due to a regression, the Yamale validator was being skipped and a variety of checks were not being performed on new metadata.

  • Update the paths so schema and metadata files are loaded and validated.
  • Update parts of the schema to work with updates to the underlying metadata:
    • Titles are no longer strictly required because they are generated for several category types.
    • long and short service names are not strictly required to be entities. This is to work around entities not always being defined for services and sub-services.
    • Switch between strict and non-strict yamale schemas based on a command-line argument. Root repo calls for strict, all other tributaries currently are non-strict.
    • Improve AWS entity check to allow non-entity usage within specific XML blocks.
    • A few other minor bug fixes and updates.

Testing

  • Add unit tests for new AWS checks.
  • Ran the validator over the full root repo metadata and I have a PR with numerous small fixes to bring that back up to standard.
  • Ran the validator over all tributaries and they all pass.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@Laren-AWS Laren-AWS self-assigned this Dec 2, 2024
@Laren-AWS Laren-AWS added the Bug An update to fix incorrect code or typos. label Dec 4, 2024
@Laren-AWS Laren-AWS merged commit 58ecee6 into main Dec 4, 2024
2 of 3 checks passed
@Laren-AWS Laren-AWS deleted the validate/yamale_schema branch December 4, 2024 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Bug An update to fix incorrect code or typos.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants