Flexible SDK validation #146
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Laren-AWS
requested review from
DavidSouther and
cpyle0819
and removed request for
DavidSouther
Laren-AWS
added
the
Task
cpyle0819
approved these changes
Feb 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes SDK validation more flexible, which lets us load SDKs defined by tributaries and validate them without requiring updates to schemas in this repo.
languagefields) in examples against the dynamically loaded list of SDKs instead of enforcing the static list from the yamale schema.strictflag to the SDK validator and when it isFalse, allow non-entity name fields.--configflag tovalidateso that a tributary can pass its config path to the validator. When this path is passed, the validator first loads default config (services, SDKs, etc.), then loads and merges the tributary config. In this way, the tributary validates its examples using the combined set of root + local config.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.