For tributary validation, load things in the right order #147
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tributaries must validate using strictly the root config + their own config. The current order is to:
Because of this, the DocGen used for loading examples in step 2 did not have the services and SDKs merged and, when the examples are loaded, preliminary validation is performed (checking that the language in the example exists in the SDK list) and fails.
This PR updates the order for tributary validation to be:
In this way, at step 3 the DocGen has all of the merged config it needs and the examples pass the preliminary checks.
Testing
I refactored slightly to help write a unit test that can call validate to test the whole process instead of unit tests in isolation, and added a test to simulate validating a tributary with a custom SDK.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.