Skip to content

Commit 221b84c

Browse files
author
Tejas Ganesh Naik
committed
updated logging framework and removed region
1 parent 98fbb08 commit 221b84c

File tree

1 file changed

+24
-19
lines changed

1 file changed

+24
-19
lines changed

javav2/example_code/sqs/src/main/java/com/example/sqs/SendRecvBatch.java

Lines changed: 24 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -17,8 +17,9 @@
1717
import java.util.HashMap;
1818
import java.util.List;
1919
import java.util.Map;
20-
import java.util.logging.Level;
21-
import java.util.logging.Logger;
20+
21+
import org.slf4j.Logger;
22+
import org.slf4j.LoggerFactory;
2223
// snippet-end:[sqs.java2.sendRecvBatch.import]
2324

2425

@@ -36,13 +37,10 @@
3637
*/
3738

3839
public class SendRecvBatch {
39-
private static final Logger logger = Logger.getLogger(SendRecvBatch.class.getName());
40-
static {
41-
Logger rootLogger = Logger.getLogger("");
42-
rootLogger.setLevel(Level.WARNING);
43-
}
40+
41+
private static final Logger logger = LoggerFactory.getLogger(SendRecvBatch.class);
42+
4443
private static final SqsClient sqsClient = SqsClient.builder()
45-
.region(Region.US_WEST_2)
4644
.build();
4745

4846
// snippet-start:[sqs.java2.sendRecvBatch.sendBatch]
@@ -79,23 +77,24 @@ public static SendMessageBatchResponse sendMessages(
7977
SendMessageBatchResponse response = sqsClient.sendMessageBatch(sendBatchRequest);
8078

8179
if (!response.successful().isEmpty()) {
80+
int successCount = 0;
8281
for (SendMessageBatchResultEntry resultEntry : response.successful()) {
83-
logger.info("Message sent: " + resultEntry.messageId() + ": " +
84-
messages.get(Integer.parseInt(resultEntry.id())).getBody());
82+
successCount++;
8583
}
84+
logger.info("Successfully sent " + successCount + " messages to queue: " + queueUrl);
8685
}
8786

8887
if (!response.failed().isEmpty()) {
8988
for (BatchResultErrorEntry errorEntry : response.failed()) {
90-
logger.warning("Failed to send: " + errorEntry.id() + ": " +
89+
logger.warn("Failed to send: " + errorEntry.id() + ": " +
9190
messages.get(Integer.parseInt(errorEntry.id())).getBody());
9291
}
9392
}
9493

9594
return response;
9695

9796
} catch (SqsException e) {
98-
logger.log(Level.SEVERE, "Send messages failed to queue: " + queueUrl, e);
97+
logger.error("Send messages failed to queue: " + queueUrl, e);
9998
throw e;
10099
}
101100
}
@@ -125,14 +124,18 @@ public static List<Message> receiveMessages(String queueUrl, int maxNumber, int
125124

126125
List<Message> messages = sqsClient.receiveMessage(receiveRequest).messages();
127126

127+
int receivedCount = 0;
128128
for (Message message : messages) {
129-
logger.info("Received message: " + message.messageId() + ": " + message.body());
129+
receivedCount++;
130130
}
131131

132+
if (receivedCount > 0) {
133+
logger.info("Received " + receivedCount + " messages from queue: " + queueUrl);
134+
}
132135
return messages;
133136

134137
} catch (SqsException e) {
135-
logger.log(Level.SEVERE, "Couldn't receive messages from queue: " + queueUrl, e);
138+
logger.error("Couldn't receive messages from queue: " + queueUrl, e);
136139
throw e;
137140
}
138141
}
@@ -166,21 +169,23 @@ public static DeleteMessageBatchResponse deleteMessages(String queueUrl, List<Me
166169
DeleteMessageBatchResponse response = sqsClient.deleteMessageBatch(deleteRequest);
167170

168171
if (!response.successful().isEmpty()) {
172+
int deletedCount = 0;
169173
for (DeleteMessageBatchResultEntry resultEntry : response.successful()) {
170-
logger.info("Deleted " + messages.get(Integer.parseInt(resultEntry.id())).receiptHandle());
174+
deletedCount++;
171175
}
176+
logger.info("Successfully deleted " + deletedCount + " messages from queue: " + queueUrl);
172177
}
173178

174179
if (!response.failed().isEmpty()) {
175180
for (BatchResultErrorEntry errorEntry : response.failed()) {
176-
logger.warning("Could not delete " + messages.get(Integer.parseInt(errorEntry.id())).receiptHandle());
181+
logger.warn("Could not delete " + messages.get(Integer.parseInt(errorEntry.id())).receiptHandle());
177182
}
178183
}
179184

180185
return response;
181186

182187
} catch (SqsException e) {
183-
logger.log(Level.SEVERE, "Couldn't delete messages from queue " + queueUrl, e);
188+
logger.error("Couldn't delete messages from queue " + queueUrl, e);
184189
throw e;
185190
}
186191
}
@@ -311,7 +316,7 @@ public static void usageDemo() {
311316
}
312317

313318
} catch (IOException e) {
314-
logger.log(Level.SEVERE, "Error reading file", e);
319+
logger.error("Error reading file", e);
315320
} finally {
316321
// Clean up by deleting the queue.
317322
DeleteQueueRequest deleteQueueRequest = DeleteQueueRequest.builder()
@@ -325,7 +330,7 @@ public static void usageDemo() {
325330
System.out.println("-".repeat(88));
326331
}
327332

328-
public static void main(String[] args) {
333+
public static void main(String[] args) {
329334
usageDemo();
330335
}
331336
}

0 commit comments

Comments
 (0)