PHP: Bedrock constructor argument corrections. #6824
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DennisTraub
reviewed
Sep 9, 2024
Contributor
DennisTraub
left a comment
DennisTraub
left a comment
There was a problem hiding this comment.
Looks good. I've updated some dependencies and the region and it's good to go.
DennisTraub
requested review from
DennisTraub and
beqqrry-aws
and removed request for
DennisTraub
DennisTraub
force-pushed
the
php-sdk-quintes
branch
from
e157522 to
67f409b
Compare
DennisTraub
force-pushed
the
php-sdk-quintes
branch
from
67f409b to
f8c34f7
Compare
DennisTraub
changed the title
DennisTraub
force-pushed
the
php-sdk-quintes
branch
3 times, most recently
from
adb5d97 to
4fa3804
Compare
meyertst-aws
added
On Call Review complete
meyertst-aws
force-pushed
the
php-sdk-quintes
branch
from
4fa3804 to
8992349
Compare
ford-at-aws
added
On Call Review complete
DennisTraub
force-pushed
the
php-sdk-quintes
branch
from
8992349 to
e073651
Compare
DennisTraub
approved these changes
Oct 25, 2024
Contributor
DennisTraub
left a comment
DennisTraub
left a comment
There was a problem hiding this comment.
I added optional client injection to BedrockRuntimeService as suggested by @beqqrry-aws.
beqqrry-aws
approved these changes
Oct 30, 2024
cpyle0819
added
On Call Review complete
cpyle0819
force-pushed
the
php-sdk-quintes
branch
from
b961299 to
95044b9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PHP Bedrock and BedrockRuntime constructor arguments #6823 fix
This pull request will provide the correct arguments to the Bedrock and Bedrock runtime constructors for the PHP examples
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license