-
Notifications
You must be signed in to change notification settings - Fork 5.8k
Chore: Update examples to use reserved s3 bucket names, instead of placeholders #6858
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
99ce75d to
d4d2934
Compare
rlhagerm
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved, but those newlines at the end of the .cs files won't pass the linter. Once that's fixed it should pass the .NET check. Ruby I'm not sure about.
|
For the |
Laren-AWS
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some examples will not work as written with these names.
Pausing on this PR while we investigate alternatives.
Guidance is to go forward with this update and do a fast follow to fix any resulting issues with examples. |
ba733ef to
5197647
Compare
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.