Skip to content

Conversation

@DavidSouther
Copy link
Contributor

@DavidSouther DavidSouther commented Sep 13, 2024

git grep --cached -Iil -f ../buckets | xargs sed -I '' -f ../buckets.sed

 s/DOC-EXAMPLE-BUCKET/amzn-s3-demo-bucket/gi
s/DOC-EXAMPLE-BUCKET1/amzn-s3-demo-bucket1/gi
s/DOC-EXAMPLE-BUCKET2/amzn-s3-demo-bucket2/gi
s/DOC-EXAMPLE-BUCKET3/amzn-s3-demo-bucket3/gi
s/DOC-EXAMPLE-SOURCE-BUCKET/amzn-s3-demo-source-bucket/gi
s/DOC-EXAMPLE-DESTINATION-BUCKET/amzn-s3-demo-destination-bucket/gi
s/DOC-EXAMPLE-SOURCE-BUCKET1/amzn-s3-demo-source-bucket1/gi
s/DOC-EXAMPLE-DESTINATION-BUCKET1/amzn-s3-demo-destination-bucket1/gi
s/DOC-EXAMPLE-SOURCE-BUCKET2/amzn-s3-demo-source-bucket2/gi
s/DOC-EXAMPLE-DESTINATION-BUCKET2/amzn-s3-demo-destination-bucket2/gi
s/DOC-EXAMPLE-LOGGING-BUCKET/amzn-s3-demo-logging-bucket/gi
s/DOC-EXAMPLE-LOGGING-BUCKET1/amzn-s3-demo-logging-bucket1/gi
s/DOC-EXAMPLE-LOGGING-BUCKET2/amzn-s3-demo-logging-bucket2/gi
s/DOC-EXAMPLE-WEBSITE-BUCKET/amzn-s3-demo-website-bucket/gi
s/DOC-EXAMPLE-WEBSITE-BUCKET1/amzn-s3-demo-website-bucket1/gi
s/DOC-EXAMPLE-WEBSITE-BUCKET2/amzn-s3-demo-website-bucket2/gi
s/DOC-EXAMPLE-BUCKET--usw2-az1--x-s3/amzn-s3-demo-bucket--usw2-az1--x-s3/gi
s/DOC-EXAMPLE-BUCKET1--usw2-az1--x-s3/amzn-s3-demo-bucket1--usw2-az1--x-s3/gi
s/DOC-EXAMPLE-BUCKET2--usw2-az1--x-s3/amzn-s3-demo-bucket2--usw2-az1--x-s3/gi
s/DOC-EXAMPLE-BUCKET3--usw2-az1--x-s3/amzn-s3-demo-bucket3--usw2-az1--x-s3/gi
s/DOC-EXAMPLE-SOURCE-BUCKET--usw2-az1--x-s3/amzn-s3-demo-source-bucket--usw2-az1--x-s3/gi
s/DOC-EXAMPLE-DESTINATION-BUCKET--usw2-az1--x-s3/amzn-s3-demo-destination-bucket--usw2-az1--x-s3/gi
s/DOC-EXAMPLE-SOURCE-BUCKET1--usw2-az1--x-s3/amzn-s3-demo-source-bucket1--usw2-az1--x-s3/gi
s/DOC-EXAMPLE-DESTINATION-BUCKET1--usw2-az1--x-s3/amzn-s3-demo-destination-bucket1--usw2-az1--x-s3/gi
s/DOC-EXAMPLE-SOURCE-BUCKET2--usw2-az1--x-s3/amzn-s3-demo-source-bucket2--usw2-az1--x-s3/gi
s/DOC-EXAMPLE-DESTINATION-BUCKET2--usw2-az1--x-s3/amzn-s3-demo-destination-bucket2--usw2-az1--x-s3/gi


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@github-actions github-actions bot added C++ This issue relates to the AWS SDK for C++ DotNet-v3 This issue relates to the AWS SDK for .NET V3 Javascript-v3 This issue relates to the AWS SDK for Javascript V3 Python This issue relates to the AWS SDK for Python (boto3) Java-v2 This issue relates to the AWS SDK for Java V2 labels Sep 13, 2024
@DavidSouther DavidSouther self-assigned this Sep 14, 2024
@github-actions github-actions bot added PHP This issue relates to the AWS SDK for PHP Ruby This issue relates to the AWS SDK for Ruby Rust This issue relates to the AWS SDK for Rust (Preview) CLI Relates to the AWS CLI labels Sep 19, 2024
@DavidSouther DavidSouther changed the title Update examples to use reserved s3 bucket names, instead of placeholders Chore: Update examples to use reserved s3 bucket names, instead of placeholders Sep 20, 2024
Copy link
Contributor

@rlhagerm rlhagerm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, but those newlines at the end of the .cs files won't pass the linter. Once that's fixed it should pass the .NET check. Ruby I'm not sure about.

@DavidSouther DavidSouther added On Call Review needed This work needs an on-call review Task A general update to the code base for language clarification, missing actions, tests, etc. labels Sep 20, 2024
@DavidSouther
Copy link
Contributor Author

For the .cs newlines: git diff --name-only main... | grep '\.cs$' | xargs truncate -s -1 {}. For ruby, I disabled the Ruby linter until @ford-at-aws has an opportunity to fix them up.

Copy link
Contributor

@Laren-AWS Laren-AWS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some examples will not work as written with these names.
Pausing on this PR while we investigate alternatives.

@Laren-AWS
Copy link
Contributor

Some examples will not work as written with these names. Pausing on this PR while we investigate alternatives.

Guidance is to go forward with this update and do a fast follow to fix any resulting issues with examples.

@Laren-AWS Laren-AWS added On Call Review complete On call review complete and removed On Call Review needed This work needs an on-call review labels Sep 24, 2024
@Laren-AWS Laren-AWS merged commit 6eb03e5 into awsdocs:main Sep 24, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

C++ This issue relates to the AWS SDK for C++ CLI Relates to the AWS CLI DotNet-v3 This issue relates to the AWS SDK for .NET V3 Java-v2 This issue relates to the AWS SDK for Java V2 Javascript-v3 This issue relates to the AWS SDK for Javascript V3 On Call Review complete On call review complete PHP This issue relates to the AWS SDK for PHP Python This issue relates to the AWS SDK for Python (boto3) Ruby This issue relates to the AWS SDK for Ruby Rust This issue relates to the AWS SDK for Rust (Preview) Task A general update to the code base for language clarification, missing actions, tests, etc.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants