Update the CloudWatch scenario to meet Java standards #6898
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scmacdon
added
Java-v2
scmacdon
changed the title
scmacdon
requested review from
meyertst-aws
and removed request for
ford-at-aws
rlhagerm
requested changes
Oct 2, 2024
Contributor
rlhagerm
left a comment
rlhagerm
left a comment
There was a problem hiding this comment.
Just a few things to check.
...xample_code/cloudwatch/src/main/java/com/example/cloudwatch/scenario/CloudWatchScenario.java
Outdated
Show resolved
Hide resolved
...xample_code/cloudwatch/src/main/java/com/example/cloudwatch/scenario/CloudWatchScenario.java
Outdated
Show resolved
Hide resolved
...xample_code/cloudwatch/src/main/java/com/example/cloudwatch/scenario/CloudWatchScenario.java
Outdated
Show resolved
Hide resolved
...xample_code/cloudwatch/src/main/java/com/example/cloudwatch/scenario/CloudWatchScenario.java
Outdated
Show resolved
Hide resolved
...example_code/cloudwatch/src/main/java/com/example/cloudwatch/scenario/CloudWatchActions.java
Show resolved
Hide resolved
...example_code/cloudwatch/src/main/java/com/example/cloudwatch/scenario/CloudWatchActions.java
Show resolved
Hide resolved
...example_code/cloudwatch/src/main/java/com/example/cloudwatch/scenario/CloudWatchActions.java
Outdated
Show resolved
Hide resolved
...example_code/cloudwatch/src/main/java/com/example/cloudwatch/scenario/CloudWatchActions.java
Outdated
Show resolved
Hide resolved
rlhagerm
added
On Call Review complete
rlhagerm
approved these changes
Oct 2, 2024
Brightomeham4
approved these changes
Oct 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request updates the CLoudWatch Java scenario to meet Java standards.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.