Skip to content

Conversation

@ford-at-aws
Copy link
Contributor

@ford-at-aws ford-at-aws commented Sep 22, 2024

This pull request fixes all automated linting findings from Rubocop. It leaves roughly 50 violations that will be resolved in this story.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@ford-at-aws ford-at-aws self-assigned this Sep 22, 2024
@github-actions github-actions bot added the Ruby This issue relates to the AWS SDK for Ruby label Sep 22, 2024
@ford-at-aws ford-at-aws requested review from a team and scmacdon and removed request for a team September 23, 2024 18:35
@ford-at-aws ford-at-aws added On Call Review needed This work needs an on-call review Task A general update to the code base for language clarification, missing actions, tests, etc. labels Sep 23, 2024
@Laren-AWS Laren-AWS added On Call Review complete On call review complete and removed On Call Review needed This work needs an on-call review labels Sep 25, 2024
@Laren-AWS Laren-AWS merged commit 1b29116 into awsdocs:main Sep 25, 2024
17 of 18 checks passed
@ajschmidt8
Copy link

This PR left merge conflict annotations in some files:

  • <<<<<<< HEAD
    bucket_name = "amzn-s3-demo-bucket"
    object_key = "my-object.txt"
    target_path = "my-object-as-file.txt"
    =======
    bucket_name = 'doc-example-bucket'
    object_key = 'my-object.txt'
    target_path = 'my-object-as-file.txt'
    >>>>>>> 999c6133e (fixes)
  • <<<<<<< HEAD
    source_bucket_name = "amzn-s3-demo-bucket1"
    source_key = "my-source-file.txt"
    target_bucket_name = "amzn-s3-demo-bucket2"
    target_key = "my-target-file.txt"
    =======
    source_bucket_name = 'doc-example-bucket1'
    source_key = 'my-source-file.txt'
    target_bucket_name = 'doc-example-bucket2'
    target_key = 'my-target-file.txt'
    >>>>>>> 999c6133e (fixes)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

On Call Review complete On call review complete Ruby This issue relates to the AWS SDK for Ruby Task A general update to the code base for language clarification, missing actions, tests, etc.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants