Skip to content

Conversation

@scmacdon
Copy link
Contributor

This pull request update the Lambda Scenario.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@scmacdon scmacdon added Java-v2 This issue relates to the AWS SDK for Java V2 Basics A basic code example showing the core actions for a particular service. labels Sep 25, 2024
@scmacdon scmacdon self-assigned this Sep 25, 2024
@github-actions github-actions bot added the Python This issue relates to the AWS SDK for Python (boto3) label Sep 25, 2024
@github-actions github-actions bot added C++ This issue relates to the AWS SDK for C++ DotNet-v3 This issue relates to the AWS SDK for .NET V3 Go-v2 This issue relates to the AWS SDK for Go V2 Javascript-v3 This issue relates to the AWS SDK for Javascript V3 Kotlin This issue relates to the AWS SDK for Kotlin PHP This issue relates to the AWS SDK for PHP Ruby This issue relates to the AWS SDK for Ruby Rust This issue relates to the AWS SDK for Rust (Preview) SAP ABAP This issue relates to the AWS SDK for SAP ABAP labels Sep 25, 2024
@rlhagerm rlhagerm removed their request for review September 30, 2024 16:38
@scmacdon scmacdon requested review from ford-at-aws and meyertst-aws and removed request for ford-at-aws and meyertst-aws October 7, 2024 14:17
Copy link
Contributor

@ford-at-aws ford-at-aws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed, break into 2 PR's: 1 updating the WRITEME script and re-running it, and 1 modifying Java examples.

@scmacdon
Copy link
Contributor Author

As discussed, break into 2 PR's: 1 updating the WRITEME script and re-running it, and 1 modifying Java examples.

Its not really 2 PRs. The Write Check was not happy until I updated all of this by running write on all Lambda Readmes. So its was more of a prerequisite to get this check to pass. It all passes now and the Java updated can be made.

@ford-at-aws
Copy link
Contributor

ford-at-aws commented Oct 22, 2024

It all passes now

This is 1 PR

...and the Java updated can be made.

This is 2nd PR.

@scmacdon scmacdon added the On Call Review needed This work needs an on-call review label Oct 22, 2024
@ford-at-aws ford-at-aws added On Call Review complete On call review complete and removed On Call Review needed This work needs an on-call review labels Oct 23, 2024
@ford-at-aws ford-at-aws merged commit 5718285 into awsdocs:main Oct 24, 2024
15 checks passed
@scmacdon scmacdon deleted the lambda3 branch November 26, 2024 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Basics A basic code example showing the core actions for a particular service. C++ This issue relates to the AWS SDK for C++ DotNet-v3 This issue relates to the AWS SDK for .NET V3 Go-v2 This issue relates to the AWS SDK for Go V2 Java-v2 This issue relates to the AWS SDK for Java V2 Javascript-v3 This issue relates to the AWS SDK for Javascript V3 Kotlin This issue relates to the AWS SDK for Kotlin On Call Review complete On call review complete PHP This issue relates to the AWS SDK for PHP Python This issue relates to the AWS SDK for Python (boto3) Ruby This issue relates to the AWS SDK for Ruby Rust This issue relates to the AWS SDK for Rust (Preview) SAP ABAP This issue relates to the AWS SDK for SAP ABAP

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants