JavaScript (v3): S3 - Standardize S3 examples as per the audit. 🧵 1/2 #6932

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

rlhagerm merged 34 commits into awsdocs:main from cpyle0819:corepyle/s3-audit

Oct 2, 2024

Contributor

cpyle0819 commented Sep 26, 2024

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

cpyle0819 added the Task label

cpyle0819 requested a review from a team

September 26, 2024 13:52

cpyle0819 self-assigned this

cpyle0819 requested review from ford-at-aws and removed request for a team

September 26, 2024 13:52

github-actions bot added the Javascript-v3 label

cpyle0819 force-pushed the corepyle/s3-audit branch 2 times, most recently from 0d9c2f2 to d486025 Compare

September 26, 2024 20:16

ford-at-aws reviewed

View reviewed changes

javascriptv3/example_code/s3/actions/delete-objects.js Show resolved Hide resolved

ford-at-aws reviewed

View reviewed changes

javascriptv3/example_code/s3/actions/delete-bucket-website.js Show resolved Hide resolved

ford-at-aws reviewed

View reviewed changes

javascriptv3/example_code/s3/actions/delete-object.js Show resolved Hide resolved

ford-at-aws reviewed

View reviewed changes

javascriptv3/example_code/s3/actions/get-object-legal-hold.js Show resolved Hide resolved

ford-at-aws reviewed

View reviewed changes

javascriptv3/example_code/s3/actions/get-object-legal-hold.js Show resolved Hide resolved

ford-at-aws reviewed

View reviewed changes

javascriptv3/example_code/s3/actions/get-object-lock-configuration.js Show resolved Hide resolved

ford-at-aws reviewed

View reviewed changes

javascriptv3/example_code/s3/actions/put-bucket-policy.js Show resolved Hide resolved

ford-at-aws reviewed

View reviewed changes

javascriptv3/example_code/s3/actions/put-object.js Show resolved Hide resolved

ford-at-aws suggested changes

View reviewed changes

Contributor

ford-at-aws left a comment

Great start! Just a few minor things.

ford-at-aws suggested changes

View reviewed changes

Contributor

ford-at-aws left a comment

Great start! Just a few minor things.

cpyle0819 force-pushed the corepyle/s3-audit branch from aa5bd47 to a4ec440 Compare

September 30, 2024 18:28

cpyle0819 requested a review from ford-at-aws

October 1, 2024 16:12

ford-at-aws approved these changes

View reviewed changes

Contributor

ford-at-aws left a comment

lgtm

cpyle0819 added the On Call Review needed label

rlhagerm added On Call Review complete and removed On Call Review needed labels

cpyle0819 added 6 commits

October 2, 2024 10:05


          JavaScript (v3): S3 - Standardize hello example.

8120c36


          JavaScript (v3): S3 - Standardize CreateBucket example.

b9535d4


          JavaScript (v3): S3 - Standardize CopyObject example.

ede53f0


          JavaScript (v3): S3 - Standardize DeleteBucketPolicy example.

9e0cbdc


          JavaScript (v3): S3 - Standardize DeleteObject example.

9993f59


          JavaScript (v3): S3 - Standardize DeleteObjects example.

0474ae3

cpyle0819 added 27 commits

October 2, 2024 10:05


          JavaScript (v3): S3 - Standardize CopyObject example.

2efcc09


          JavaScript (v3): S3 - Update success output for standardized examples.

005c39b


          JavaScript (v3): S3 - Standardize GetBucketPolicy example.

6f58d67


          JavaScript (v3): S3 - Standardize GetObject example.

be7b4ce


          JavaScript (v3): S3 - Standardize GetObjectLegalHold example.

220f7ba


          JavaScript (v3): S3 - Ensure defaults are present in exampes with par…

5ae0acb

…ameters.


          JavaScript (v3): S3 - Ensure proper fake bucket names are used.

2f13e95


          JavaScript (v3): S3 - Standardize GetObjectLockConfiguration example.

98fa674


          JavaScript (v3): S3 - Standardize GetObjectRetention example.

31037a9


          JavaScript (v3): S3 - ListObjects example.

9af2a81


          JavaScript (v3): S3 - Standardize PutObject example.

43e18d4


          JavaScript (v3): S3 - Standardize GetBucketCors example.

abcde61


          JavaScript (v3): S3 - Standardize PutBucketCors example.


          JavaScript (v3): S3 - Standardize GetBucketAcl example.

7b911e1


          JavaScript (v3): S3 - Standardize PutBucketAcl example.

0c15f8f


          JavaScript (v3): S3 - Standardize PutBucketPolicy example.


          JavaScript (v3): S3 - Standardize PutBucketWebsite example.

a4c5c61


          JavaScript (v3): S3 - Standardize GetBucketWebsite example.

7aac840


          JavaScript (v3): S3 - Fix bad snippet tag and run writeme.

7591c4b


          JavaScript (v3): S3 - Fix formatting issue.

56de85c


          JavaScript (v3): S3 - Standardize ListBuckets example.


          JavaScript (v3): S3 - Standardize PutObjectLegalHold example and flip…

1e3d9e2

… ouput of unique name util.


          JavaScript (v3): S3 - Standardize PutObjectLockConfiguration example.

cf3cde8


          Metadata: Remove accidental copy pasta.

32edab0


          JavaScript (v3): S3 - Fix grammatical error in GetObjectLegalHold exa…

d010867

…mple.


          JavaScript (v3): S3 - Use a more likely error for PutBucketPolicy exa…

faf1006

…mple.


          JavaScript (v3): S3 - Use a more educational error for PutObject exam…

6af2361

…ple.

rlhagerm force-pushed the corepyle/s3-audit branch from f5c92fc to 6af2361 Compare

October 2, 2024 15:05

rlhagerm merged commit c319089 into awsdocs:main

14 checks passed

cpyle0819 deleted the corepyle/s3-audit branch

October 2, 2024 18:44

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Javascript-v3 On Call Review complete Task