JavaScript (v3): Replace ESLint & Prettier with BiomeJS #6978
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cpyle0819
requested review from
a team,
DavidSouther and
meyertst-aws
and removed request for
a team and
DavidSouther
cpyle0819
added
the
Task
github-actions
bot
added
Javascript-v3
cpyle0819
added
the
Task
meyertst-aws
approved these changes
Oct 15, 2024
javascriptv3/example_code/medical-imaging/actions/update-image-set-metadata.js
Outdated
Show resolved
Hide resolved
meyertst-aws
added
On Call Review complete
Biome is the same tool used by the SDK team. It also has a much larger vocabulary of "fixable" items. It outperforms other linters and has TS/JSX support out of the box. It's error messaging is also much more helpful.
meyertst-aws
force-pushed
the
corepyle/biome
branch
from
fbcec34 to
52abee0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Biome is the same tool used by the SDK team. It also has a much larger
vocabulary of "fixable" items. It outperforms other linters and has
TS/JSX support out of the box. It's error messaging is also much more
helpful.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.