Skip to content

Conversation

@cpyle0819
Copy link
Contributor

Updated the Biome settings to error on noUndeclaredVariables and fixed the fallout.
Replaced the 'log' util with a more standard version of a logger.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@cpyle0819 cpyle0819 added the Task A general update to the code base for language clarification, missing actions, tests, etc. label Oct 18, 2024
@cpyle0819 cpyle0819 requested a review from scmacdon October 18, 2024 19:42
@cpyle0819 cpyle0819 self-assigned this Oct 18, 2024
@github-actions github-actions bot added the Javascript-v3 This issue relates to the AWS SDK for Javascript V3 label Oct 18, 2024
@cpyle0819 cpyle0819 added the On Call Review needed This work needs an on-call review label Oct 18, 2024
Copy link
Contributor

@ford-at-aws ford-at-aws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ford-at-aws ford-at-aws added On Call Review complete On call review complete and removed On Call Review needed This work needs an on-call review labels Oct 22, 2024
@ford-at-aws ford-at-aws force-pushed the corepyle/libs-scenario-parser branch from 3c49bbc to 654bd30 Compare October 22, 2024 13:32
@ford-at-aws ford-at-aws force-pushed the corepyle/libs-scenario-parser branch from 654bd30 to 86bf0b2 Compare October 22, 2024 13:36
@ford-at-aws ford-at-aws merged commit 6dc1b78 into awsdocs:main Oct 22, 2024
14 checks passed
@cpyle0819 cpyle0819 deleted the corepyle/libs-scenario-parser branch November 12, 2024 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Javascript-v3 This issue relates to the AWS SDK for Javascript V3 On Call Review complete On call review complete Task A general update to the code base for language clarification, missing actions, tests, etc.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants